Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPM] change index pattern id to be the same as index pattern title #60436

Merged
merged 1 commit into from
Mar 18, 2020
Merged

[EPM] change index pattern id to be the same as index pattern title #60436

merged 1 commit into from
Mar 18, 2020

Conversation

neptunian
Copy link
Contributor

#60388

Changes the index pattern ID to match the name of the index pattern title. In the case of EPM, the ids will be metrics-*, logs-*, events-*

@neptunian neptunian added the Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project label Mar 17, 2020
@neptunian neptunian self-assigned this Mar 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@neptunian neptunian added v7.7.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Mar 17, 2020
ruflin
ruflin approved these changes Mar 17, 2020
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming builds go green). Did you check if this fixes the dashboards?

@neptunian
Copy link
Contributor Author

@ruflin I don't get any errors the index pattern ids, but there are errors with fields not existing that the dashboard references.

@ruflin
Copy link
Contributor

ruflin commented Mar 18, 2020

@neptunian Ping me directly on the fields misssing. That might be something about the packages not complete.

@neptunian neptunian force-pushed the 60388-index-pattern-id branch from fc9f321 to b6488e0 Compare March 18, 2020 15:31
@neptunian neptunian requested a review from a team March 18, 2020 15:31
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@neptunian neptunian merged commit 4c9d953 into elastic:master Mar 18, 2020
@neptunian neptunian mentioned this pull request Mar 18, 2020
Merged
jloleysens added a commit that referenced this pull request Mar 18, 2020
@jloleysens
Merge branch 'app/painless' of github.com:elastic/kibana into app/pai…
8733480 
…nless

* 'app/painless' of github.com:elastic/kibana: (64 commits)
  Fix filter scope in bool query (#60488)
  change index pattern id to be the same as index pattern title (#60436)
  [Endpoint] resolver v1 events (#59233)
  Branding fixes for dashboard, loader and space selector (#60073)
  skip flaky suite (#60535)
  [SIEM][Detection Engine] Fixes bug with timeline templates not working
  Fixed errors which are happening if switch between alert types (#60453)
  [EPM] Add mapping field types to index template generation v2 (#60266)
  [NP] Cutover ensureDefaultIndexPattern to kibana_utils (#59895)
  Closes #60265. Adds Beta badge to service map (#60482)
  [Visualize] Duplicated query filters in es request (#60106)
  [ML] Disable functional transform tests
  Fixes to service map single node banner (#60072)
  [Uptime] replace fetch with kibana http (#59881)
  Upgrade @types/node to match Node.js runtime (#60368)
  [License Management] NP migration (#60250)
  Fix create alert button from not showing in alerts list (#60444)
  [SIEM][Case] Update connector through flyout (#60307)
  add data-test-subj where possible on SO management table (#60226)
  Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (#60406)
  ...
neptunian added a commit that referenced this pull request Mar 18, 2020
@neptunian
change index pattern id to be the same as index pattern title (#60436) (
ec9f3ec 
#60542)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Mar 19, 2020
@jloleysens
Merge remote-tracking branch 'upstream/app/painless' into minor-refactor
3f00238 
* upstream/app/painless: (66 commits)
  Another i18n issue
  Fix i18n
  Fix filter scope in bool query (elastic#60488)
  change index pattern id to be the same as index pattern title (elastic#60436)
  [Endpoint] resolver v1 events (elastic#59233)
  Branding fixes for dashboard, loader and space selector (elastic#60073)
  skip flaky suite (elastic#60535)
  [SIEM][Detection Engine] Fixes bug with timeline templates not working
  Fixed errors which are happening if switch between alert types (elastic#60453)
  [EPM] Add mapping field types to index template generation v2 (elastic#60266)
  [NP] Cutover ensureDefaultIndexPattern to kibana_utils (elastic#59895)
  Closes elastic#60265. Adds Beta badge to service map (elastic#60482)
  [Visualize] Duplicated query filters in es request (elastic#60106)
  [ML] Disable functional transform tests
  Fixes to service map single node banner (elastic#60072)
  [Uptime] replace fetch with kibana http (elastic#59881)
  Upgrade @types/node to match Node.js runtime (elastic#60368)
  [License Management] NP migration (elastic#60250)
  Fix create alert button from not showing in alerts list (elastic#60444)
  [SIEM][Case] Update connector through flyout (elastic#60307)
  ...
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees

@neptunian neptunian

Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@neptunian @elasticmachine @ruflin @kibanamachine @jen-huang