Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add data-test-subj where possible on SO management table #60226

Merged
merged 4 commits into from
Mar 18, 2020
Merged

add data-test-subj where possible on SO management table #60226

merged 4 commits into from
Mar 18, 2020

Conversation

pgayvallet
Copy link
Contributor

@pgayvallet pgayvallet commented Mar 16, 2020 •
edited
Loading

Summary

Add data-test-subj attributes on SO management table

Related to #59758

@pgayvallet pgayvallet added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 16, 2020
@pgayvallet pgayvallet requested a review from a team as a code owner March 16, 2020 07:42
@pgayvallet pgayvallet requested review from bhavyarm and LeeDr March 16, 2020 07:42
@pgayvallet pgayvallet linked an issue Mar 16, 2020 that may be closed by this pull request
Add rowProps to saved objects management table #59758
Closed
@pgayvallet pgayvallet mentioned this pull request Mar 16, 2020
Closed
lizozom
lizozom approved these changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bhavyarm
Copy link
Contributor

cc @dmlemeshko

@bhavyarm
Copy link
Contributor

cc @LeeDr

bhavyarm
bhavyarm reviewed Mar 16, 2020
View reviewed changes
Copy link
Contributor

@bhavyarm bhavyarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeeDr
Copy link

LeeDr commented Mar 16, 2020

@pgayvallet does this comment on the issue help at all? Even if they can't be dynamic and incorporate the title in the data-test-subj, it would be good to have static ones;
#59758 (comment)

@pgayvallet
Copy link
Contributor Author

@LeeDr replied to cchaos. Waiting for her answer to see what our options are

@pgayvallet
Copy link
Contributor Author

@LeeDr added per-action data-test-subj following the savedObjectsTableAction-${action.id} format.

Do you see anything else to add?

@LeeDr
Copy link

LeeDr commented Mar 17, 2020

Thanks! I'll pull this and test it locally soon.

LeeDr
LeeDr approved these changes Mar 17, 2020
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks! Bhavya pulled and ran it in both OSS and defaultDist mode and we checked out the data-tests-subj's together.

@bhavyarm
Copy link
Contributor

@LeeDr and I tested this both on OSS and x-pack. Looks good to us. Thanks @pgayvallet Thanks @cchaos for rocking this! More tests!!!!!

@pgayvallet
Copy link
Contributor Author

retest

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit d466cc9 into elastic:master Mar 18, 2020
@pgayvallet pgayvallet mentioned this pull request Mar 18, 2020
Merged
pgayvallet added a commit to pgayvallet/kibana that referenced this pull request Mar 18, 2020
@pgayvallet
add data-test-subj where possible on SO management table (elastic#60226)
2ca762c 
* add data-test-subj where possible

* add per-action dts

* update snapshots
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 18, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
4584654 
* master:
  [License Management] NP migration (elastic#60250)
  Fix create alert button from not showing in alerts list (elastic#60444)
  [SIEM][Case] Update connector through flyout (elastic#60307)
  add data-test-subj where possible on SO management table (elastic#60226)
  Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (elastic#60406)
pgayvallet added a commit that referenced this pull request Mar 18, 2020
@pgayvallet
add data-test-subj where possible on SO management table (#60226) (#6…
93661af 
…0493)

* add data-test-subj where possible

* add per-action dts

* update snapshots
jloleysens added a commit that referenced this pull request Mar 18, 2020
@jloleysens
Merge branch 'app/painless' of github.com:elastic/kibana into app/pai…
8733480 
…nless

* 'app/painless' of github.com:elastic/kibana: (64 commits)
  Fix filter scope in bool query (#60488)
  change index pattern id to be the same as index pattern title (#60436)
  [Endpoint] resolver v1 events (#59233)
  Branding fixes for dashboard, loader and space selector (#60073)
  skip flaky suite (#60535)
  [SIEM][Detection Engine] Fixes bug with timeline templates not working
  Fixed errors which are happening if switch between alert types (#60453)
  [EPM] Add mapping field types to index template generation v2 (#60266)
  [NP] Cutover ensureDefaultIndexPattern to kibana_utils (#59895)
  Closes #60265. Adds Beta badge to service map (#60482)
  [Visualize] Duplicated query filters in es request (#60106)
  [ML] Disable functional transform tests
  Fixes to service map single node banner (#60072)
  [Uptime] replace fetch with kibana http (#59881)
  Upgrade @types/node to match Node.js runtime (#60368)
  [License Management] NP migration (#60250)
  Fix create alert button from not showing in alerts list (#60444)
  [SIEM][Case] Update connector through flyout (#60307)
  add data-test-subj where possible on SO management table (#60226)
  Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (#60406)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 19, 2020
@gmmorris
rge branch 'alerting/tls-warning' of github.com:gmmorris/kibana into …
38c5e1e 
…alerting/tls-warning

* 'alerting/tls-warning' of github.com:gmmorris/kibana: (33 commits)
  [ML] Disable functional transform tests
  Fixes to service map single node banner (elastic#60072)
  [Uptime] replace fetch with kibana http (elastic#59881)
  Upgrade @types/node to match Node.js runtime (elastic#60368)
  [License Management] NP migration (elastic#60250)
  Fix create alert button from not showing in alerts list (elastic#60444)
  [SIEM][Case] Update connector through flyout (elastic#60307)
  add data-test-subj where possible on SO management table (elastic#60226)
  Enforce `required` presence for value/key validation of `recordOf` and `mapOf`. (elastic#60406)
  [ML] Re-enabling file upload telemetry (elastic#60418)
  [NP] Use local helper shortenDottedString for discover (elastic#60271)
  [Console] Fix for `_settings` and x-pack autocomplete (elastic#60246)
  Task/host enhancements (elastic#59671)
  [Search service] Asynchronous ES search strategy (elastic#53538)
  Index Action - Moved index params fields to connector config (elastic#60349)
  Edits UI text for ML nodes and job button (elastic#60184)
  Publish getIsNavDrawerLocked$ method on core chrome service. (elastic#60191)
  Disabled edit alert button on management ui for non registered UI alert types (elastic#60439)
  Revert "[Console] Fix bool filter autocompletions and refactor (elastic#60361)"
  [Console] Fix bool filter autocompletions and refactor (elastic#60361)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhavyarm bhavyarm bhavyarm left review comments

@LeeDr LeeDr LeeDr approved these changes

@lizozom lizozom lizozom approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add rowProps to saved objects management table
5 participants
@pgayvallet @bhavyarm @LeeDr @kibanamachine @lizozom