-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Transforms: Use EuiInMemoryTable instead of custom typed table. #59782
[ML] Transforms: Use EuiInMemoryTable instead of custom typed table. #59782
Conversation
Pinging @elastic/ml-ui (:ml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM.
@@ -186,52 +182,46 @@ export const TransformList: FC<Props> = ({ | |||
// Before the transforms have been loaded for the first time, display the loading indicator only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this comment still valid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's still relevant.
💔 Build FailedTest FailuresKibana Pipeline / x-pack-intake-agent / X-Pack Jest Tests.x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list.Transform: Transform List Minimal initializationStandard Out
Stack Trace
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM ⚡️
…lastic#59782) Before EuiInMemoryTable had TypeScript support we used our own typings and some state & CSS fixes. This is now all solved by the original EUI component. - Use EuiInMemoryTable instead of custom typed table. - Deletes some legacy leftover files.
* master: [ML] Transforms: Use EuiInMemoryTable instead of custom typed table. (elastic#59782) Alerting/fix flaky instance test (elastic#58994) ci: disable all Mocha rules for tape tests (elastic#59798) Fix UX in alerting UI forms when errors occur (elastic#59444) [DOCS] Updated and added jump tables (elastic#59774) [DOCS] Moved rolled up index content (elastic#59372) Regenerate core api docs (elastic#59814) [Lens] remove react warnings (elastic#59574) The scripts/backport.js file isn't an executable (elastic#59800) [Alerting] add more alert properties to action parameter templating (elastic#59718) [Design] Branding changes in Elastic to focus more towards the Elastic brand (elastic#58160) [SIEM] Adds 'Create new rule' Cypress test (elastic#59790) Updating svgo -> css-tree -> mdn-data, all so we get mdn-data > 2.0 (elastic#58913) Use EUI test environment build with Jest (elastic#55877) update typescript version in all packages to avoid warnings (elastic#59787) [SIEM] [Case] Insert timeline into case textarea (elastic#59586) [ML] Functional tests - stabilize saved search tests (elastic#59652)
#59782 was merged with failing test. Signed-off-by: Tyler Smalley <[email protected]>
Summary
Before
EuiInMemoryTable
had TypeScript support we used our own typings and some state & CSS fixes. This is now all solved by the original EUI component.Note for
kibana-design
: NoSCSS
files where modified, just deleted some overrides.Checklist
For maintainers