-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] [Case] Insert timeline into case textarea #59586
Merged
stephmilovic
merged 22 commits into
elastic:master
from
stephmilovic:insert-timeline-case
Mar 10, 2020
Merged
[SIEM] [Case] Insert timeline into case textarea #59586
stephmilovic
merged 22 commits into
elastic:master
from
stephmilovic:insert-timeline-case
Mar 10, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephmilovic
added
Team:SIEM
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.7.0
labels
Mar 6, 2020
Pinging @elastic/siem (Team:SIEM) |
stephmilovic
commented
Mar 6, 2020
x-pack/legacy/plugins/siem/public/components/markdown_editor/index.tsx
Outdated
Show resolved
Hide resolved
stephmilovic
commented
Mar 6, 2020
...gacy/plugins/siem/public/components/timeline/insert_timeline_popover/use_insert_timeline.tsx
Outdated
Show resolved
Hide resolved
stephmilovic
commented
Mar 7, 2020
stephmilovic
commented
Mar 7, 2020
x-pack/legacy/plugins/siem/public/components/markdown_editor/index.tsx
Outdated
Show resolved
Hide resolved
stephmilovic
commented
Mar 7, 2020
stephmilovic
changed the title
[SIEM] [Case] [skip-ci] Insert timeline into case textarea
[SIEM] [Case] Insert timeline into case textarea
Mar 7, 2020
@elasticmachine merge upstream |
XavierM
reviewed
Mar 10, 2020
x-pack/legacy/plugins/siem/public/components/markdown_editor/index.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Mar 10, 2020
x-pack/legacy/plugins/siem/public/components/timeline/insert_timeline_popover/popover.tsx
Outdated
Show resolved
Hide resolved
XavierM
reviewed
Mar 10, 2020
...gacy/plugins/siem/public/components/timeline/insert_timeline_popover/use_insert_timeline.tsx
Show resolved
Hide resolved
stephmilovic
force-pushed
the
insert-timeline-case
branch
from
March 10, 2020 14:38
04d0d57
to
60d01fb
Compare
XavierM
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's really nice feature that you offer to our users. 💪 💪 💪
Thank you for the hard work
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
Mar 10, 2020
stephmilovic
added a commit
that referenced
this pull request
Mar 10, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Mar 11, 2020
* master: [ML] Transforms: Use EuiInMemoryTable instead of custom typed table. (elastic#59782) Alerting/fix flaky instance test (elastic#58994) ci: disable all Mocha rules for tape tests (elastic#59798) Fix UX in alerting UI forms when errors occur (elastic#59444) [DOCS] Updated and added jump tables (elastic#59774) [DOCS] Moved rolled up index content (elastic#59372) Regenerate core api docs (elastic#59814) [Lens] remove react warnings (elastic#59574) The scripts/backport.js file isn't an executable (elastic#59800) [Alerting] add more alert properties to action parameter templating (elastic#59718) [Design] Branding changes in Elastic to focus more towards the Elastic brand (elastic#58160) [SIEM] Adds 'Create new rule' Cypress test (elastic#59790) Updating svgo -> css-tree -> mdn-data, all so we get mdn-data > 2.0 (elastic#58913) Use EUI test environment build with Jest (elastic#55877) update typescript version in all packages to avoid warnings (elastic#59787) [SIEM] [Case] Insert timeline into case textarea (elastic#59586) [ML] Functional tests - stabilize saved search tests (elastic#59652)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #58017
This PR implements the insert timeline into markdown functionality.
Areas to manually test: