Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Migrate Context mocha tests to use Jest #59658

Conversation

kertal
Copy link
Member

@kertal kertal commented Mar 9, 2020

Summary

Migrate Context mocha tests to Jest to be fit for Kibana Platform

Part of #54339

Checklist

Delete any items that are not applicable to this PR.

@kertal kertal changed the title [Discover] Migrate Context mocha tests to use jest [Discover] Migrate Context mocha tests to use Jest Mar 9, 2020
@kertal kertal self-assigned this Mar 9, 2020
@kertal kertal added Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal kertal added the v7.7.0 label Mar 9, 2020
@kertal kertal added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 labels Mar 12, 2020
@kertal kertal marked this pull request as ready for review March 12, 2020 05:17
@kertal kertal requested review from a team and flash1293 March 12, 2020 05:17
@kertal
Copy link
Member Author

kertal commented Mar 12, 2020

@elasticmachine merge upstream

kertal added 2 commits March 12, 2020 14:43
…ts' of github.com:kertal/kibana into kertal-pr-2020-03-09-discover-migrate-context-mocha-tests
@kertal kertal requested a review from flash1293 March 12, 2020 13:56
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, didn't test locally. Very good call consolidating all of these tests in a single file 💯

@kertal kertal merged commit 5605dfa into elastic:master Mar 12, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 12, 2020
* master: (45 commits)
  skip flaky suite (elastic#59717)
  UI Metrics use findAll to retrieve all Saved Objects (elastic#59891)
  [Discover] Migrate Context mocha tests to use Jest (elastic#59658)
  [Maps] Move redux reducers and store logic to NP (elastic#58294)
  rebalance x-pack groups (elastic#58930)
  [Discover] Reimplement $route.reload when index pattern changes (elastic#59877)
  [Upgrade Assistant Meta] Breaking changes issue template (elastic#59745)
  Skip CI based on changes in PR (elastic#59939)
  [ML] Transforms: Replace KqlFilterBar with QueryStringInput. (elastic#59723)
  [ML] Functional tests - stabilize date_nanos test (elastic#59986)
  [ML] Typescripting client side endpoint functions (elastic#59928)
  a11y tests on adding columns to discover table (elastic#59375)
  fix graph plugin config path (elastic#59540)
  fix vega config issues (elastic#59737)
  [Upgrade Assistant] Open And Close Slight Refactor (elastic#59890)
  [ML] Adding shared services to ml setup contract (elastic#59730)
  [Visualize] Fix linked search behavior (elastic#59690)
  [ML] Register NP ML plugin for Kibana management section. (elastic#59762)
  [Lens] Adds using queries/filters for field existence endpoint (elastic#59033)
  Delete FilterStateManager and QueryFilter :-D (elastic#59872)
  ...
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 59658 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 13, 2020
kertal added a commit to kertal/kibana that referenced this pull request Mar 13, 2020
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants