Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rebalance x-pack groups #58930

Merged
merged 12 commits into from
Mar 12, 2020
Merged

rebalance x-pack groups #58930

merged 12 commits into from
Mar 12, 2020

Conversation

LeeDr
Copy link

@LeeDr LeeDr commented Feb 28, 2020

Summary

The long-pole job xpack-kibana-ciGroup3 - (1 hr 17 min in self) was adding about 30 minutes to all Kibana ci jobs. I moved things around to even them out. With this change the longest job should be xpack-kibana-ciGroup6 - (48 min in self).

We might be able to reduce that 48 a couple of minutes, but the average is almost 42 minutes so there's not much improvement to be made without adding another ciGroup.

Execute kibana-ciGroup1 - (18 min in self)			Console Output	Success
Execute kibana-ciGroup2 - (8 min 17 sec in self)		Console Output	Success
Execute kibana-ciGroup3 - (18 min in self)			Console Output	Success
Execute kibana-ciGroup4 - (15 min in self)			Console Output	Success
Execute kibana-ciGroup5 - (12 min in self)			Console Output	Success
Execute kibana-ciGroup6 - (22 min in self)			Console Output	Success
Execute kibana-ciGroup7 - (16 min in self)			Console Output	Success
Execute kibana-ciGroup8 - (13 min in self)			Console Output	Success
Execute kibana-ciGroup9 - (16 min in self)			Console Output	Success
Execute kibana-ciGroup10 - (15 min in self)			Console Output	Success
Execute kibana-ciGroup11 - (17 min in self)			Console Output	Success
Execute kibana-ciGroup12 - (19 min in self)			Console Output	Success
Branch: oss-accessibility - (11 min in block)				Success

Execute xpack-kibana-ciGroup1 - (40 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup2 - (45 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup3 - (1 hr 17 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup4 - (45 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup5 - (30 min in self)			Console Output	Success - 
Execute xpack-kibana-ciGroup6 - (48 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup7 - (38 min in self)			Console Output	Success 40
Execute xpack-kibana-ciGroup8 - (33 min in self)			Console Output	Success 39.5
Execute xpack-kibana-ciGroup9 - (31 min in self)			Console Output	Success 40.5
Execute xpack-kibana-ciGroup10 - (30 min in self)			Console Output	Success - 38


(these are just my notes from Jenkins to see how long various tests ran)

x-pack/test/functional/apps/dashboard/index.ts:    this.tags('ciGroup3'); 2 minutes > group 7 ~40
00:38:24.380         └-: dashboard

x-pack/test/functional/apps/discover/index.ts:    this.tags('ciGroup3'); 6.5 minutes > group 8 ~39.5
00:40:16.717         └-: discover

x-pack/test/functional/apps/machine_learning/index.ts:    this.tags('ciGroup3'); 37 minutes
00:46:45.501         └-: machine learning

x-pack/test/functional/apps/dev_tools/index.ts:    this.tags('ciGroup3'); 4 minutes > group 10
01:23:40.574         └-: console 

x-pack/test/functional/apps/index_management/index.ts:    this.tags('ciGroup3');  1 minute
01:27:39.968         └-: Index Management app

01:27:50.669       │685 passing (49.0m)
01:27:50.669       │30 pending


x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/index.ts:    this.tags('ciGroup3');
01:28:54.984         └-: Actions and Triggers app                       4 minutes group 10
01:32:46.503       │21 passing (3.0m)
01:32:46.503       │13 pending

x-pack/test/alerting_api_integration/spaces_only/tests/index.ts:    this.tags('ciGroup3');
01:33:51.546         └-: alerting api integration spaces only           4 minutes  > group 9
01:37:08.003       │58 passing (3.0m)

x-pack/test/alerting_api_integration/security_and_spaces/tests/index.ts:    this.tags('ciGroup3');
01:38:12.479         └-: alerting api integration security and spaces enabled 4.5 minutes group 9
01:52:57.892       │454 passing (14.0m)

@LeeDr LeeDr added test v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 28, 2020
@LeeDr LeeDr requested a review from a team as a code owner February 28, 2020 19:36
mikecote
mikecote approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alerting changes LGTM!

@LeeDr
Copy link
Author

LeeDr commented Feb 29, 2020

@elasticmachine merge upstream

@LeeDr
Copy link
Author

LeeDr commented Feb 29, 2020

The last job failed on some x-pack Jest tests, but here's the timing of the functional tests;
What I'm seeing is that the times vary quite a bit from one run to the next even with no changes in the ciGroup.

Execute xpack-kibana-ciGroup1 - (40 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup2 - (47 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup3 - (42 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup4 - (46 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup5 - (47 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup6 - (50 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup7 - (41 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup8 - (42 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup9 - (37 min in self)			Console Output	Success
Execute xpack-kibana-ciGroup10 - (41 min in self)			Console Output	Success
Branch: xpack-accessibility - (8 min 0 sec in block)				Success

@LeeDr
Copy link
Author

LeeDr commented Mar 2, 2020

@elasticmachine merge upstream

@LeeDr
Copy link
Author

LeeDr commented Mar 2, 2020

@elasticmachine merge upstream

@brianseeders
Copy link
Contributor

Interesting, I've been seeing that ERROR UnexpectedAlertOpenError: unexpected alert open: {Alert text : } on a branch I have open that also re-arranges the order that tests are run in

@LeeDr
Copy link
Author

LeeDr commented Mar 3, 2020

@elasticmachine merge upstream

@LeeDr
Copy link
Author

LeeDr commented Mar 4, 2020

@elasticmachine merge upstream

@LeeDr
Copy link
Author

LeeDr commented Mar 4, 2020

Seems like this PR needs this fix #59329

YulNaumenko added a commit to YulNaumenko/kibana that referenced this pull request Mar 5, 2020
@YulNaumenko
Rebalancing CI groups according to elastic#58930
4d9a3c3
YulNaumenko added a commit that referenced this pull request Mar 6, 2020
@YulNaumenko
Add custom action to registry and show actions list in siem (#58395)
5ff13ad 
* Add custom action to registry and show actions list in siem

* Exposed action form as reusable component

* Fixed few small bugs

* Fixed red ci

* Fixed type checks

* Fixed failed tests

* Fixed due to comments

* Fixed type check errors

* Fixed plugin check

* Rebalancing CI groups according to #58930

* Fixed merge issues
@LeeDr
Copy link
Author

LeeDr commented Mar 11, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented Mar 11, 2020

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented Mar 11, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

spalger
spalger approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LeeDr LeeDr merged commit 69fd44e into elastic:master Mar 12, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Mar 12, 2020
@gmmorris
Merge branch 'master' into alerting/view-in-app
fc5b17c 
* master: (45 commits)
  skip flaky suite (elastic#59717)
  UI Metrics use findAll to retrieve all Saved Objects (elastic#59891)
  [Discover] Migrate Context mocha tests to use Jest (elastic#59658)
  [Maps] Move redux reducers and store logic to NP (elastic#58294)
  rebalance x-pack groups (elastic#58930)
  [Discover] Reimplement $route.reload when index pattern changes (elastic#59877)
  [Upgrade Assistant Meta] Breaking changes issue template (elastic#59745)
  Skip CI based on changes in PR (elastic#59939)
  [ML] Transforms: Replace KqlFilterBar with QueryStringInput. (elastic#59723)
  [ML] Functional tests - stabilize date_nanos test (elastic#59986)
  [ML] Typescripting client side endpoint functions (elastic#59928)
  a11y tests on adding columns to discover table (elastic#59375)
  fix graph plugin config path (elastic#59540)
  fix vega config issues (elastic#59737)
  [Upgrade Assistant] Open And Close Slight Refactor (elastic#59890)
  [ML] Adding shared services to ml setup contract (elastic#59730)
  [Visualize] Fix linked search behavior (elastic#59690)
  [ML] Register NP ML plugin for Kibana management section. (elastic#59762)
  [Lens] Adds using queries/filters for field existence endpoint (elastic#59033)
  Delete FilterStateManager and QueryFilter :-D (elastic#59872)
  ...
@LeeDr LeeDr mentioned this pull request Mar 12, 2020
Merged
LeeDr pushed a commit to LeeDr/kibana that referenced this pull request Mar 12, 2020
@elasticmachine @spalger
rebalance x-pack groups (elastic#58930)
5049e8b 
* rebalance x-pack groups

* fix typo in ciGroup10

* move from group 9 to group 5

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: spalger <[email protected]>
LeeDr pushed a commit that referenced this pull request Mar 12, 2020
@elasticmachine @spalger
rebalance x-pack groups (#58930) (#60050)
4b95995 
* rebalance x-pack groups

* fix typo in ciGroup10

* move from group 9 to group 5

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: spalger <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: spalger <[email protected]>
@LeeDr LeeDr deleted the rebalanceXpackGroups branch March 12, 2020 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikecote mikecote mikecote approved these changes

@spalger spalger spalger approved these changes

@brianseeders brianseeders Awaiting requested review from brianseeders

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes test v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LeeDr @brianseeders @spalger @kibanamachine @mikecote @elasticmachine