Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][App Arch] migrate legacy CSS to new platform (core_plugins/visualizations) #59027

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/legacy/core_plugins/visualizations/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export const visualizations: LegacyPluginInitializer = kibana =>
publicDir: resolve(__dirname, 'public'),
require: [],
uiExports: {
styleSheetPaths: resolve(__dirname, 'public/index.scss'),
styleSheetPaths: resolve(__dirname, 'public/np_ready/public/index.scss'),
},
});

Expand Down
2 changes: 0 additions & 2 deletions src/legacy/core_plugins/visualizations/public/index.scss

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -1 +1 @@
@import 'visualization';
@import './visualization';
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
@import 'visualize_lab_disabled';
@import 'embeddables';
@import './visualize_lab_disabled';
@import './embeddables';
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// Due the plugin is located on the old platform we should leave import of constants.
// It will be removed when "visualizations" will migrate to the new platform
@import 'src/legacy/ui/public/styles/styling_constants';

@import './wizard/index';
@import './embeddable/index';
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,8 @@ import { UiActionsStart } from '../../../../../../plugins/ui_actions/public';
import { DataStart as LegacyDataStart } from '../../../../data/public';
import { VisState } from './types';

import './index.scss';

/**
* Interface for this plugin's returned setup/start contracts.
*
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1 @@
@import 'dialog';
@import './dialog';
2 changes: 1 addition & 1 deletion src/legacy/ui/public/_index.scss
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,4 @@

// Can't import vis folder here because of cascading issues, it's imported in core_plugins/kibana
// @import './vis/index';
@import './visualize/index';
@import '../../core_plugins/visualizations/public/np_ready/public/components/index';
1 change: 0 additions & 1 deletion src/legacy/ui/public/visualize/_index.scss

This file was deleted.