[WIP][App Arch] migrate legacy CSS to new platform (core_plugins/visualizations) #59027

VladLasitsa · 2020-03-02T12:56:47Z

Summary

Here's a list of app arch legacy items I've found so far which contain some scss (be sure to look around for anything I may have missed):

core_plugins/visualizations

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

cchaos

The new imports looks good to me. Now you can also remove the old imports and files that referenced the old _index.scss file. Like:

And then check this reference/import:
https://github.com/elastic/kibana/blob/f74b63faa71dc6a517382a991871786d0925bc19/src/legacy/ui/public/visualize/_index.scss

alexwizp

Do we still need the following code:

  styleSheetPaths: resolve(__dirname, 'public/index.scss'),

in src/legacy/core_plugins/visualizations/index.ts

cchaos · 2020-03-02T14:20:56Z

@alexwizp No, as mentioned above, the uiExports can be removed.

VladLasitsa · 2020-03-02T15:11:44Z

The new imports looks good to me. Now you can also remove the old imports and files that referenced the old _index.scss file. Like:

https://github.com/elastic/kibana/blob/f74b63faa71dc6a517382a991871786d0925bc19/src/legacy/core_plugins/visualizations/public/index.scss

https://github.com/elastic/kibana/blob/f74b63faa71dc6a517382a991871786d0925bc19/src/legacy/core_plugins/visualizations/index.ts#L28-L30

And then check this reference/import:
https://github.com/elastic/kibana/blob/f74b63faa71dc6a517382a991871786d0925bc19/src/legacy/ui/public/visualize/_index.scss

Done

elasticmachine · 2020-03-02T15:12:39Z

Pinging @elastic/kibana-app-arch (Team:AppArch)

VladLasitsa · 2020-03-02T15:14:05Z

@elasticmachine merge upstream

VladLasitsa · 2020-03-02T15:14:54Z

Do we still need the following code:
  styleSheetPaths: resolve(__dirname, 'public/index.scss'),
in src/legacy/core_plugins/visualizations/index.ts

removed

cchaos

All the references look ok to me. But I'm asking for a review from @elastic/kibana-app team as they know the visualization file structure better.

VladLasitsa · 2020-03-03T07:31:20Z

@elasticmachine merge upstream

VladLasitsa · 2020-03-03T14:48:15Z

@elasticmachine merge upstream

VladLasitsa · 2020-03-09T10:47:47Z

@elasticmachine merge upstream

kibanamachine · 2020-03-10T18:05:41Z

💛 Build succeeded, but was flaky

continuous-integration/kibana-ci/pull-request
Commit: f3e317a
Flaky suites:
- kibana-ciGroup2

Test Failures

Kibana Pipeline / kibana-oss-agent / Chrome UI Functional Tests.test/functional/apps/dashboard/dashboard_query_bar·js.dashboard app using current data dashboard query bar causes panels to reload when refresh is clicked

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 5 times on tracked branches: https://github.com/elastic/kibana/issues/59615

[00:00:00]       │
[00:00:00]         └-: dashboard app
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: using current data
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> "before all" hook: loadCurrentData
[00:00:00]               │ info [dashboard/current/data] Loading "mappings.json"
[00:00:00]               │ info [dashboard/current/data] Loading "data.json.gz"
[00:00:00]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [animals-dogs-2018-01-01] creating index, cause [api], templates [], shards [5]/[1], mappings [_doc]
[00:00:00]               │ info [dashboard/current/data] Created index "animals-dogs-2018-01-01"
[00:00:00]               │ debg [dashboard/current/data] "animals-dogs-2018-01-01" settings {"index":{"number_of_replicas":"1","number_of_shards":"5"}}
[00:00:00]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [animals-dogs-2018-04-10] creating index, cause [api], templates [], shards [5]/[1], mappings [_doc]
[00:00:00]               │ info [dashboard/current/data] Created index "animals-dogs-2018-04-10"
[00:00:00]               │ debg [dashboard/current/data] "animals-dogs-2018-04-10" settings {"index":{"number_of_replicas":"1","number_of_shards":"5"}}
[00:00:00]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [animals-cats-2018-01-01] creating index, cause [api], templates [], shards [5]/[1], mappings [_doc]
[00:00:00]               │ info [dashboard/current/data] Created index "animals-cats-2018-01-01"
[00:00:00]               │ debg [dashboard/current/data] "animals-cats-2018-01-01" settings {"index":{"number_of_replicas":"1","number_of_shards":"5"}}
[00:00:00]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [animals-cats-2018-04-10] creating index, cause [api], templates [], shards [5]/[1], mappings [_doc]
[00:00:00]               │ info [dashboard/current/data] Created index "animals-cats-2018-04-10"
[00:00:00]               │ debg [dashboard/current/data] "animals-cats-2018-04-10" settings {"index":{"number_of_replicas":"1","number_of_shards":"5"}}
[00:00:00]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [dogbreeds] creating index, cause [api], templates [], shards [5]/[1], mappings [_doc]
[00:00:00]               │ info [dashboard/current/data] Created index "dogbreeds"
[00:00:00]               │ debg [dashboard/current/data] "dogbreeds" settings {"index":{"number_of_replicas":"1","number_of_shards":"5"}}
[00:00:00]               │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [logstash-0] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:00:00]               │ info [dashboard/current/data] Created index "logstash-0"
[00:00:00]               │ debg [dashboard/current/data] "logstash-0" settings {"index":{"analysis":{"analyzer":{"makelogs_url":{"max_token_length":"1000","tokenizer":"uax_url_email","type":"standard"}}},"number_of_replicas":"0","number_of_shards":"1"}}
[00:00:10]               │ info progress: 11965
[00:00:11]               │ info [dashboard/current/data] Indexed 6 docs into "animals-dogs-2018-01-01"
[00:00:11]               │ info [dashboard/current/data] Indexed 6 docs into "animals-dogs-2018-04-10"
[00:00:11]               │ info [dashboard/current/data] Indexed 6 docs into "animals-cats-2018-01-01"
[00:00:11]               │ info [dashboard/current/data] Indexed 5 docs into "animals-cats-2018-04-10"
[00:00:11]               │ info [dashboard/current/data] Indexed 6 docs into "dogbreeds"
[00:00:11]               │ info [dashboard/current/data] Indexed 14005 docs into "logstash-0"
[00:05:23]             └-: dashboard query bar
[00:05:23]               └-> "before all" hook
[00:05:23]               └-> "before all" hook
[00:05:23]                 │ info [dashboard/current/kibana] Loading "mappings.json"
[00:05:23]                 │ info [dashboard/current/kibana] Loading "data.json.gz"
[00:05:23]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana_1/Ig6gYWy2RoStb2MRpdiQmg] deleting index
[00:05:23]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana_2/hNCskKe8TLiLAmBRLmBPAA] deleting index
[00:05:23]                 │ info [dashboard/current/kibana] Deleted existing index [".kibana_2",".kibana_1"]
[00:05:23]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:05:23]                 │ info [dashboard/current/kibana] Created index ".kibana"
[00:05:23]                 │ debg [dashboard/current/kibana] ".kibana" settings {"index":{"auto_expand_replicas":"0-1","number_of_replicas":"0","number_of_shards":"1"}}
[00:05:23]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana/6NYL85o3Sc6QMY-IvvxqZg] update_mapping [_doc]
[00:05:23]                 │ info [dashboard/current/kibana] Indexed 84 docs into ".kibana"
[00:05:23]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana/6NYL85o3Sc6QMY-IvvxqZg] update_mapping [_doc]
[00:05:23]                 │ debg Migrating saved objects
[00:05:23]                 │ proc [kibana]   log   [16:44:54.624] [info][savedobjects-service] Creating index .kibana_2.
[00:05:23]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:05:23]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] updating number_of_replicas to [0] for indices [.kibana_2]
[00:05:23]                 │ proc [kibana]   log   [16:44:54.685] [info][savedobjects-service] Reindexing .kibana to .kibana_1
[00:05:23]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:05:23]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] updating number_of_replicas to [0] for indices [.kibana_1]
[00:05:24]                 │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] 5370 finished with response BulkByScrollResponse[took=49.3ms,timed_out=false,sliceId=null,updated=0,created=84,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:05:24]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana/6NYL85o3Sc6QMY-IvvxqZg] deleting index
[00:05:24]                 │ proc [kibana]   log   [16:44:55.027] [info][savedobjects-service] Migrating .kibana_1 saved objects to .kibana_2
[00:05:24]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana_2/vpQd9fSPRDiF0y7JYkafxQ] update_mapping [_doc]
[00:05:24]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana_2/vpQd9fSPRDiF0y7JYkafxQ] update_mapping [_doc]
[00:05:24]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana_2/vpQd9fSPRDiF0y7JYkafxQ] update_mapping [_doc]
[00:05:24]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana_2/vpQd9fSPRDiF0y7JYkafxQ] update_mapping [_doc]
[00:05:24]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana_2/vpQd9fSPRDiF0y7JYkafxQ] update_mapping [_doc]
[00:05:24]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana_2/vpQd9fSPRDiF0y7JYkafxQ] update_mapping [_doc]
[00:05:24]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana_2/vpQd9fSPRDiF0y7JYkafxQ] update_mapping [_doc]
[00:05:24]                 │ proc [kibana]   log   [16:44:55.275] [info][savedobjects-service] Pointing alias .kibana to .kibana_2.
[00:05:24]                 │ proc [kibana]   log   [16:44:55.323] [info][savedobjects-service] Finished in 705ms.
[00:05:24]                 │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:05:24]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [.kibana_2/vpQd9fSPRDiF0y7JYkafxQ] update_mapping [_doc]
[00:05:24]                 │ debg browser[INFO] http://localhost:6121/bundles/plugin/data/data.plugin.js 90:139970 "INFO: 2020-03-10T16:44:55Z
[00:05:24]                 │        Adding connection to http://localhost:6121/elasticsearch
[00:05:24]                 │
[00:05:24]                 │      "
[00:05:25]                 │ debg replacing kibana config doc: {"defaultIndex":"0bf35f60-3dc9-11e8-8660-4d65aa086b3c"}
[00:05:26]                 │ debg navigating to dashboard url: http://localhost:6121/app/kibana#/dashboards
[00:05:26]                 │ debg Navigate to: http://localhost:6121/app/kibana#/dashboards
[00:05:26]                 │ debg ... sleep(700) start
[00:05:27]                 │ debg browser[INFO] http://localhost:6121/app/kibana?_t=1583858697710#/dashboards 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:05:27]                 │
[00:05:27]                 │ debg browser[INFO] http://localhost:6121/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:05:27]                 │ debg ... sleep(700) end
[00:05:27]                 │ debg returned from get, calling refresh
[00:05:28]                 │ debg browser[INFO] http://localhost:6121/bundles/plugin/data/data.plugin.js 90:139970 "INFO: 2020-03-10T16:44:59Z
[00:05:28]                 │        Adding connection to http://localhost:6121/elasticsearch
[00:05:28]                 │
[00:05:28]                 │      "
[00:05:28]                 │ERROR browser[SEVERE] http://localhost:6121/bundles/commons.bundle.js 0:1401248 TypeError: Failed to fetch
[00:05:28]                 │          at Fetch._callee3$ (http://localhost:6121/bundles/commons.bundle.js:1:1428405)
[00:05:28]                 │          at l (http://localhost:6121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:338:1041918)
[00:05:28]                 │          at Generator._invoke (http://localhost:6121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:338:1041671)
[00:05:28]                 │          at Generator.forEach.e.<computed> [as throw] (http://localhost:6121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:338:1042275)
[00:05:28]                 │          at asyncGeneratorStep (http://localhost:6121/bundles/commons.bundle.js:1:1422902)
[00:05:28]                 │          at _throw (http://localhost:6121/bundles/commons.bundle.js:1:1423299)
[00:05:28]                 │ debg browser[INFO] http://localhost:6121/app/kibana?_t=1583858697710#/dashboards 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:05:28]                 │
[00:05:28]                 │ debg browser[INFO] http://localhost:6121/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:05:28]                 │ debg currentUrl = http://localhost:6121/app/kibana#/dashboards
[00:05:28]                 │          appUrl = http://localhost:6121/app/kibana#/dashboards
[00:05:28]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:05:30]                 │ debg TestSubjects.find(kibanaChrome)
[00:05:30]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:05:30]                 │ debg browser[INFO] http://localhost:6121/bundles/plugin/data/data.plugin.js 90:139970 "INFO: 2020-03-10T16:45:00Z
[00:05:30]                 │        Adding connection to http://localhost:6121/elasticsearch
[00:05:30]                 │
[00:05:30]                 │      "
[00:05:30]                 │ debg ... sleep(501) start
[00:05:30]                 │ debg ... sleep(501) end
[00:05:30]                 │ debg in navigateTo url = http://localhost:6121/app/kibana#/dashboards?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:05:30]                 │ debg --- retry.try error: URL changed, waiting for it to settle
[00:05:31]                 │ debg ... sleep(501) start
[00:05:31]                 │ debg ... sleep(501) end
[00:05:31]                 │ debg in navigateTo url = http://localhost:6121/app/kibana#/dashboards?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))
[00:05:31]                 │ debg TestSubjects.exists(statusPageContainer)
[00:05:31]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:05:34]                 │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:05:34]                 │ debg isGlobalLoadingIndicatorVisible
[00:05:34]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:05:34]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:05:34]                 │ debg browser[INFO] http://localhost:6121/app/kibana#/dashboards?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now)) 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:05:34]                 │
[00:05:34]                 │ debg browser[INFO] http://localhost:6121/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:05:36]                 │ debg browser[INFO] http://localhost:6121/bundles/plugin/data/data.plugin.js 90:139970 "INFO: 2020-03-10T16:45:07Z
[00:05:36]                 │        Adding connection to http://localhost:6121/elasticsearch
[00:05:36]                 │
[00:05:36]                 │      "
[00:05:36]                 │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:05:37]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:05:37]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:05:37]                 │ debg Load Saved Dashboard dashboard with filter
[00:05:37]                 │ debg gotoDashboardLandingPage
[00:05:37]                 │ debg onDashboardLandingPage
[00:05:37]                 │ debg TestSubjects.exists(dashboardLandingPage)
[00:05:37]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=5000
[00:05:37]                 │ debg searchForItemWithName: dashboard with filter
[00:05:37]                 │ debg Find.allByCssSelector('.euiFieldSearch') with timeout=10000
[00:05:38]                 │ debg isGlobalLoadingIndicatorVisible
[00:05:38]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:05:38]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:05:38]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:05:38]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:05:38]                 │ debg TestSubjects.click(dashboardListingTitleLink-dashboard-with-filter)
[00:05:38]                 │ debg Find.clickByCssSelector('[data-test-subj="dashboardListingTitleLink-dashboard-with-filter"]') with timeout=10000
[00:05:38]                 │ debg Find.findByCssSelector('[data-test-subj="dashboardListingTitleLink-dashboard-with-filter"]') with timeout=10000
[00:05:38]                 │ debg isGlobalLoadingIndicatorVisible
[00:05:38]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:05:38]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:05:39]                 │ debg browser[WARNING] http://localhost:6121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 5:99123 "Deprecation warning: value provided is not in a recognized RFC2822 or ISO format. moment construction falls back to js Date(), which is not reliable across all browsers and versions. Non RFC2822/ISO date formats are discouraged and will be removed in an upcoming major release. Please refer to http://momentjs.com/guides/#/warnings/js-date/ for more info.
[00:05:39]                 │      Arguments: 
[00:05:39]                 │      [0] _isAMomentObject: true, _isUTC: false, _useUTC: false, _l: undefined, _i: Mon Apr 09 2018 17:56:08 GMT-0400, _f: undefined, _strict: undefined, _locale: [object Object]
[00:05:39]                 │      Error
[00:05:39]                 │          at Function.createFromInputFallback (http://localhost:6121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:6:99531)
[00:05:39]                 │          at http://localhost:6121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:6:119281
[00:05:39]                 │          at http://localhost:6121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:6:119332
[00:05:39]                 │          at Ct (http://localhost:6121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:6:119626)
[00:05:39]                 │          at St (http://localhost:6121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:6:120003)
[00:05:39]                 │          at Mt (http://localhost:6121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:6:120085)
[00:05:39]                 │          at o (http://localhost:6121/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js:6:96369)
[00:05:39]                 │          at Function.convertTimeToUTCString (http://localhost:6121/bundles/7.bundle.js:1:33781)
[00:05:39]                 │          at Function.areTimesEqual (http://localhost:6121/bundles/7.bundle.js:1:33969)
[00:05:39]                 │          at DashboardStateManager.getTimeChanged (http://localhost:6121/bundles/7.bundle.js:1:163398)"
[00:05:39]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:05:39]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:05:39]                 │ debg TestSubjects.missingOrFail(dashboardLandingPage)
[00:05:39]                 │ debg Find.waitForDeletedByCssSelector('[data-test-subj="dashboardLandingPage"]') with timeout=10000
[00:05:39]               └-> causes panels to reload when refresh is clicked
[00:05:39]                 └-> "before each" hook: global before each
[00:05:39]                 │ info [dashboard/current/data] Unloading indices from "mappings.json"
[00:05:39]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [animals-dogs-2018-01-01/sD6tXN2HR56dDMk_DjJBmg] deleting index
[00:05:39]                 │ info [dashboard/current/data] Deleted existing index "animals-dogs-2018-01-01"
[00:05:39]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [animals-dogs-2018-04-10/Q_EITnICTraZjnzHiCzkRQ] deleting index
[00:05:40]                 │ info [dashboard/current/data] Deleted existing index "animals-dogs-2018-04-10"
[00:05:40]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [animals-cats-2018-01-01/rJMhU2YwS0qGrXQnBvRk8Q] deleting index
[00:05:40]                 │ info [dashboard/current/data] Deleted existing index "animals-cats-2018-01-01"
[00:05:40]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [animals-cats-2018-04-10/3pVR1iY6TTat220sPT_Gtw] deleting index
[00:05:40]                 │ info [dashboard/current/data] Deleted existing index "animals-cats-2018-04-10"
[00:05:40]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [dogbreeds/wODFf3JDQAOqlVRG47ntOg] deleting index
[00:05:40]                 │ info [dashboard/current/data] Deleted existing index "dogbreeds"
[00:05:40]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1583857327923327648] [logstash-0/wPt1ug8UTIOWJ89xek0Xag] deleting index
[00:05:40]                 │ info [dashboard/current/data] Deleted existing index "logstash-0"
[00:05:40]                 │ info [dashboard/current/data] Unloading indices from "data.json.gz"
[00:05:41]                 │ debg TestSubjects.click(querySubmitButton)
[00:05:41]                 │ debg Find.clickByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:05:41]                 │ debg Find.findByCssSelector('[data-test-subj="querySubmitButton"]') with timeout=10000
[00:05:41]                 │ debg TestSubjects.find(embeddedSavedSearchDocTable)
[00:05:41]                 │ debg Find.findByCssSelector('[data-test-subj="embeddedSavedSearchDocTable"]') with timeout=10000
[00:05:41]                 │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/dashboard app using current data dashboard query bar causes panels to reload when refresh is clicked.png"
[00:05:41]                 │ info Current URL is: http://localhost:6121/app/kibana#/dashboard/61c58ad0-3dd3-11e8-b2b9-5d5dc1715159?_g=(filters:!(),refreshInterval:(pause:!t,value:0),time:(from:%27Mon%20Apr%2009%202018%2017:56:08%20GMT-0400%27,to:%27Wed%20Apr%2011%202018%2017:56:08%20GMT-0400%27))&_a=(description:%27%27,filters:!((%27$state%27:(store:appState),meta:(alias:!n,disabled:!f,index:a0f483a0-3dc9-11e8-8660-4d65aa086b3c,key:animal,negate:!f,params:(query:dog,type:phrase),type:phrase,value:dog),query:(match:(animal:(query:dog,type:phrase))))),fullScreenMode:!f,options:(darkTheme:!f,hidePanelTitles:!f,useMargins:!t),panels:!((embeddableConfig:(),gridData:(h:15,i:%271%27,w:24,x:0,y:0),id:%2750643b60-3dd3-11e8-b2b9-5d5dc1715159%27,panelIndex:%271%27,type:visualization,version:%278.0.0-SNAPSHOT%27),(embeddableConfig:(),gridData:(h:15,i:%272%27,w:24,x:24,y:0),id:a16d1990-3dca-11e8-8660-4d65aa086b3c,panelIndex:%272%27,type:search,version:%278.0.0-SNAPSHOT%27)),query:(language:lucene,query:%27%27),timeRestore:!t,title:%27dashboard%20with%20filter%27,viewMode:view)
[00:05:41]                 │ info Saving page source to: /dev/shm/workspace/kibana/test/functional/failure_debug/html/dashboard app using current data dashboard query bar causes panels to reload when refresh is clicked.html
[00:05:41]                 └- ✖ fail: "dashboard app using current data dashboard query bar causes panels to reload when refresh is clicked"
[00:05:41]                 │

Stack Trace

Error: expected 6 to equal 0
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.be.Assertion.equal (packages/kbn-expect/expect.js:227:8)
    at Assertion.be (packages/kbn-expect/expect.js:69:22)
    at Context.it (test/functional/apps/dashboard/dashboard_query_bar.js:45:33)
    at process._tickCallback (internal/process/next_tick.js:68:7)

History

💔 Build #31694 failed 43255b0faf4d65e4d647483a153b0f6e28159cb4
💔 Build #31129 failed 5960de5ca87913b1cb16bd895c453f019f70c695
💔 Build #30373 failed 4cc64217aafd0921525aceb7472a22f564d952b8
💔 Build #30355 failed 4b5389808d639d6d7154434eac0efde77d9666da
💔 Build #30276 failed c905281363788cdc019174feb62e07ed9a9da341

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alexwizp · 2020-03-12T08:48:39Z

Blocked by #44121

VladLasitsa requested a review from alexwizp March 2, 2020 12:56

alexwizp requested a review from cchaos March 2, 2020 13:28

cchaos reviewed Mar 2, 2020

View reviewed changes

alexwizp requested changes Mar 2, 2020

View reviewed changes

lukeelmers mentioned this pull request Mar 2, 2020

[App Arch] migrate legacy CSS to new platform #55493

Closed

10 tasks

VladLasitsa self-assigned this Mar 2, 2020

VladLasitsa added Feature:NP Migration Team:AppArch labels Mar 2, 2020

VladLasitsa added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Mar 2, 2020

VladLasitsa marked this pull request as ready for review March 2, 2020 15:14

VladLasitsa requested review from a team as code owners March 2, 2020 15:14

cchaos requested a review from a team March 2, 2020 15:17

cchaos approved these changes Mar 2, 2020

View reviewed changes

VladLasitsa added 4 commits March 10, 2020 13:26

core_plugins/visualizations - migrate legacy CSS to new platform

3fecc7f

Removed old references

1e97e67

fixed imports for styles inside components

0e8167e

Fixed imports

f3e317a

VladLasitsa force-pushed the migrate_legacy_CSS branch from 43255b0 to f3e317a Compare March 10, 2020 16:21

alexwizp changed the title ~~[App Arch] migrate legacy CSS to new platform~~ [WIP][App Arch] migrate legacy CSS to new platform Mar 11, 2020

alexwizp added the WIP Work in progress label Mar 11, 2020

alexwizp changed the title ~~[WIP][App Arch] migrate legacy CSS to new platform~~ [WIP][App Arch] migrate legacy CSS to new platform (core_plugins/visualizations) Mar 16, 2020

VladLasitsa closed this Mar 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP][App Arch] migrate legacy CSS to new platform (core_plugins/visualizations) #59027

[WIP][App Arch] migrate legacy CSS to new platform (core_plugins/visualizations) #59027

VladLasitsa commented Mar 2, 2020

cchaos left a comment

alexwizp left a comment

cchaos commented Mar 2, 2020

VladLasitsa commented Mar 2, 2020

elasticmachine commented Mar 2, 2020

VladLasitsa commented Mar 2, 2020

VladLasitsa commented Mar 2, 2020

cchaos left a comment

VladLasitsa commented Mar 3, 2020

VladLasitsa commented Mar 3, 2020

VladLasitsa commented Mar 9, 2020

kibanamachine commented Mar 10, 2020

Standard Out

Stack Trace

alexwizp commented Mar 12, 2020

[WIP][App Arch] migrate legacy CSS to new platform (core_plugins/visualizations) #59027

[WIP][App Arch] migrate legacy CSS to new platform (core_plugins/visualizations) #59027

Conversation

VladLasitsa commented Mar 2, 2020

Summary

Checklist

For maintainers

cchaos left a comment

Choose a reason for hiding this comment

alexwizp left a comment

Choose a reason for hiding this comment

cchaos commented Mar 2, 2020

VladLasitsa commented Mar 2, 2020

elasticmachine commented Mar 2, 2020

VladLasitsa commented Mar 2, 2020

VladLasitsa commented Mar 2, 2020

cchaos left a comment

Choose a reason for hiding this comment

VladLasitsa commented Mar 3, 2020

VladLasitsa commented Mar 3, 2020

VladLasitsa commented Mar 9, 2020

kibanamachine commented Mar 10, 2020

💛 Build succeeded, but was flaky

Test Failures

Standard Out

Stack Trace

History

alexwizp commented Mar 12, 2020