Expose savedObject import / export utility methods #58882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgayvallet
added
Team:Core
|
Pinging @elastic/kibana-platform (Team:Platform) |
legrego
approved these changes
Feb 28, 2020
mshustov
approved these changes
Mar 2, 2020
| supportedTypes: string[]; | ||
| /** if specified, will import in given namespace */ |
There was a problem hiding this comment.
if unspecified, it will import as a non-namespaced object. updated comment.
| overwrite: boolean; | ||
| /** client to use to perform the import operation */ |
There was a problem hiding this comment.
nit: {@link SavedObjectsClientContract | saved objects client }?
src/core/server/index.ts
Outdated
| @@ -229,6 +229,9 @@ export { | |||
| SavedObjectsType, | |||
| SavedObjectMigrationMap, | |||
| SavedObjectMigrationFn, | |||
| getSortedObjectsForExport, | |||
There was a problem hiding this comment.
optional:
getSortedObjectsForExport doesn't return saved objects, but a stream of them.
importSavedObjects doesn't accept saved objects, but a stream of them.
what if we reflect this fact in the naming?
exportToStream/importFromStream for example
rudolf
approved these changes
Mar 2, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Mar 4, 2020
* add getImportExportObjectLimit to so setup * expose static method for so import / export * improve functions naming * fix mocked reference
pgayvallet
added a commit
that referenced
this pull request
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #58854
getImportExportObjectLimitmethod to SOsetupapigetSortedObjectsForExport,importSavedObjectsandresolveImportErrorsfromsrc/core/serverChecklist
Delete any items that are not applicable to this PR.