Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Platform] Add import/export API to core SO service #58854

Closed
pgayvallet opened this issue Feb 28, 2020 · 3 comments · Fixed by #58882
Closed

[Platform] Add import/export API to core SO service #58854

pgayvallet opened this issue Feb 28, 2020 · 3 comments · Fixed by #58882
Labels
blocker Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

Need to add the import/export APIs that were exposed in the legacy SO service to the core SO service, as the spaces plugin uses them.

importExport: {
objectLimit: server.config().get('savedObjects.maxImportExportSize'),
importSavedObjects,
resolveImportErrors,
getSortedObjectsForExport,
},

@pgayvallet pgayvallet added blocker Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Feb 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet
Copy link
Contributor Author

Except from the objectLimit that needs an accessors, all other methods are static utility that don't have any context, and could be just exported from src/core/server. Not sure if we prefer that, or to add them to the SO start contract?

@rudolf
Copy link
Contributor

rudolf commented Feb 28, 2020

I'm 👍 for just exposing these as static utilities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants