[Step 2] ui/persisted_state 👉 src/plugins/visualizations #58501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
tests failed on plugin generator, this usually means that browser karma tests fail |
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
alexwizp
added
release_note:skip
|
@elasticmachine merge upstream |
Dosant
approved these changes
Feb 27, 2020
| * under the License. | ||
| */ | ||
|
|
||
| import { EventEmitter } from 'events'; |
There was a problem hiding this comment.
nit:
looks like this is not an explicit kibana dependency in package.json even-though is used in bunch of places.
I guess we should add it to package.json.
There was a problem hiding this comment.
Thanks for pointing me into it. I didn't know it is automatic shimming, I though it is just transitive dependency
flash1293
approved these changes
Feb 27, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Feb 27, 2020
Co-authored-by: Elastic Machine <[email protected]>
alexwizp
added a commit
that referenced
this pull request
Feb 28, 2020
…8770) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #46926
Summary
Checklist
Delete any items that are not applicable to this PR.
For maintainers