Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vislib legend toggle broken #59254

Closed
nickofthyme opened this issue Mar 4, 2020 · 3 comments · Fixed by #59736
Closed

Vislib legend toggle broken #59254

nickofthyme opened this issue Mar 4, 2020 · 3 comments · Fixed by #59736
Assignees
@nickofthyme @alexwizp
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Vislib Vislib chart implementation regression Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0

Comments

@nickofthyme
Copy link
Contributor

Kibana version:
8.0.0

Elasticsearch version:
8.0.0

Server OS version:

Browser version:
Chrome Version 80.0.3987.122

Original install method (e.g. download page, yum, from source, etc.):
Local

Describe the bug:
Legend toggle in vislib charts not functioning correctly.

Steps to reproduce:

  1. Start kibana with sample data
  2. Open sample vislib visualization with or without a legend.
  3. Click on the legend toggle in the bottom left corner of the chart and notice the toggle does not work.

Expected behavior:
Toggle button toggles on and off the chart legend.

Screenshots:
Screen Recording 2020-03-03 at 07 04 PM
@nickofthyme nickofthyme added bug Fixes for quality problems that affect the customer experience Feature:Vislib Vislib chart implementation Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@nickofthyme nickofthyme self-assigned this Mar 9, 2020
@nickofthyme
Copy link
Contributor Author

nickofthyme commented Mar 9, 2020 •
edited
Loading

git bisect shows this commit created the issue.

[29e984a] [Step 2] ui/persisted_state 👉 src/plugins/visualizations (#58501)

@nickofthyme
Copy link
Contributor Author

@alexwizp would you have time to look into this issue?

@alexwizp alexwizp self-assigned this Mar 10, 2020
alexwizp added a commit to alexwizp/kibana that referenced this issue Mar 10, 2020
@alexwizp
Vislib legend toggle broken
4af7817 
Closes: elastic#59254
@alexwizp alexwizp mentioned this issue Mar 10, 2020
Merged
7 tasks
alexwizp added a commit that referenced this issue Mar 11, 2020
@alexwizp
Vislib legend toggle broken (#59736)
bd3f94e 
Closes: #59254
alexwizp added a commit to alexwizp/kibana that referenced this issue Mar 11, 2020
@alexwizp
Vislib legend toggle broken (elastic#59736)
c212a23 
Closes: elastic#59254
alexwizp added a commit that referenced this issue Mar 12, 2020
@alexwizp @elasticmachine
Vislib legend toggle broken (#59736) (#59893)
bb9ee41 
Closes: #59254

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickofthyme nickofthyme

@alexwizp alexwizp

Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:Vislib Vislib chart implementation regression Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Vislib legend toggle broken alexwizp/kibana
4 participants
@timroes @elasticmachine @nickofthyme @alexwizp