Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TS for vis_type_table #58347

Merged
merged 4 commits into from
Feb 26, 2020
Merged

Conversation

maryia-lapata
Copy link
Contributor

Fix TS for vis_type_table

Fixes #49551.

@maryia-lapata maryia-lapata added Feature:Data Table Data table visualization feature Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.7.0 labels Feb 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@maryia-lapata
Copy link
Contributor Author

@elasticmachine merge upstream

@maryia-lapata
Copy link
Contributor Author

@elasticmachine merge upstream

Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maryia-lapata maryia-lapata marked this pull request as ready for review February 26, 2020 07:45
@maryia-lapata maryia-lapata added the release_note:skip Skip the PR/issue when compiling release notes label Feb 26, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and still works

@maryia-lapata maryia-lapata merged commit 39f6eaf into elastic:master Feb 26, 2020
@maryia-lapata maryia-lapata deleted the eslint-update branch February 26, 2020 10:21
maryia-lapata added a commit that referenced this pull request Feb 26, 2020
* Remove eslint overrides for vis_type_table

* Fix TS for vis_type_table

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Feature:Data Table Data table visualization feature release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove temporary src/legacy/core_plugins/vis_type_table eslint overrides
5 participants