Fix TS for vis_type_table (#58347)

* Remove eslint overrides for vis_type_table * Fix TS for vis_type_table Co-authored-by: Elastic Machine <[email protected]>
elastic · Feb 26, 2020 · 39f6eaf · 39f6eaf
1 parent a4e82c4
commit 39f6eaf
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -82,12 +82,6 @@ module.exports = {
         'react-hooks/exhaustive-deps': 'off',
       },
     },
-    {
-      files: ['src/legacy/core_plugins/vis_type_table/**/*.{js,ts,tsx}'],
-      rules: {
-        'react-hooks/exhaustive-deps': 'off',
-      },
-    },
     {
       files: [
         'src/legacy/core_plugins/vis_default_editor/public/components/controls/**/*.{ts,tsx}',

diff --git a/src/legacy/core_plugins/vis_type_table/public/components/table_vis_options.tsx b/src/legacy/core_plugins/vis_type_table/public/components/table_vis_options.tsx
@@ -47,14 +47,14 @@ function TableOptions({
         .filter(col => get(col.aggConfig.type.getFormat(col.aggConfig), 'type.id') === 'number')
         .map(({ name }) => ({ value: name, text: name })),
     ],
-    [aggs, stateParams.percentageCol, stateParams.dimensions]
+    [aggs]
   );
 
   const isPerPageValid = stateParams.perPage === '' || stateParams.perPage > 0;
 
   useEffect(() => {
     setValidity(isPerPageValid);
-  }, [isPerPageValid]);
+  }, [isPerPageValid, setValidity]);
 
   useEffect(() => {
     if (
@@ -64,7 +64,7 @@ function TableOptions({
     ) {
       setValue('percentageCol', percentageColumns[0].value);
     }
-  }, [percentageColumns, stateParams.percentageCol]);
+  }, [percentageColumns, stateParams.percentageCol, setValidity, setValue]);
 
   return (
     <EuiPanel paddingSize="s">