Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TS for vis_type_vislib #58345

Merged
merged 14 commits into from
Mar 4, 2020
Merged

Fix TS for vis_type_vislib #58345

merged 14 commits into from
Mar 4, 2020

Conversation

maryia-lapata
Copy link
Contributor

@maryia-lapata maryia-lapata commented Feb 24, 2020 •
edited
Loading

Fix TS for vis_type_vislib

Fixes #49546.

@maryia-lapata maryia-lapata added Feature:Vislib Vislib chart implementation Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.0.0 v7.7.0 labels Feb 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@maryia-lapata
Copy link
Contributor Author

@elasticmachine merge upstream

@maryia-lapata
Copy link
Contributor Author

@elasticmachine merge upstream

@maryia-lapata maryia-lapata added the release_note:skip Skip the PR/issue when compiling release notes label Feb 26, 2020
@maryia-lapata
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

merge conflict between base and head

@maryia-lapata
Copy link
Contributor Author

@elasticmachine merge upstream

@maryia-lapata maryia-lapata marked this pull request as ready for review February 26, 2020 14:07
@maryia-lapata maryia-lapata requested a review from a team February 26, 2020 14:07
@maryia-lapata
Copy link
Contributor Author

@elasticmachine merge upstream

@maryia-lapata
Copy link
Contributor Author

@elasticmachine merge upstream

sulemanof
sulemanof reviewed Mar 3, 2020
View reviewed changes
.../core_plugins/vis_type_vislib/public/components/options/metrics_axes/category_axis_panel.tsx
@@ -89,7 +89,7 @@ function CategoryAxisPanel(props: CategoryAxisPanelProps) {
setValue={setAxis}
/>

{axis.show && <LabelOptions axis={axis} axesName="categoryAxes" index={0} {...props} />}
{axis.show && <LabelOptions axesName="categoryAxes" index={0} {...props} />}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you touched this, could you please also optimize the LabelOptions component ?
This component is only relied on several params, but accepts all of VisOptionsProps<BasicVislibParams>.
Could be decreased (and could be helpful for performance, since will not cause additional re-rendering):

<LabelOptions 
    axisLabels={axis.labels}
    axisFilterCheckboxName={`xAxisFilterLabelsCheckbox${axis.id}`}
    setAxisLabel={setAxisLabel} />

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, don't worry about this anymore!
I prepared a PR with refactoring based on your current pr:
#59135

sulemanof
sulemanof approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@sulemanof sulemanof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

kertal
kertal approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@kertal kertal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM 👍 , tested locally in Chrome, nice cleanups inside

@maryia-lapata maryia-lapata merged commit 80db96b into elastic:master Mar 4, 2020
@maryia-lapata maryia-lapata deleted the fix-lint-vislib branch March 4, 2020 10:57
@maryia-lapata maryia-lapata mentioned this pull request Mar 4, 2020
Merged
maryia-lapata added a commit that referenced this pull request Mar 4, 2020
@maryia-lapata @elasticmachine
Fix TS for vis_type_vislib (#58345) (#59293)
575d709 
* Fix TS for vislib

* Fix TS

* Revert table changes

* Update unit test

* Refactor updateAxisTitle

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulemanof sulemanof sulemanof approved these changes

@kertal kertal kertal approved these changes

Assignees
No one assigned
Labels
backported Feature:Vislib Vislib chart implementation release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove temporary src/legacy/core_plugins/kbn_vislib_vis_types eslint overrides
5 participants
@maryia-lapata @elasticmachine @kibanamachine @kertal @sulemanof