Refactor updateAxisTitle

elastic · Mar 3, 2020 · 45a7a21 · 45a7a21
1 parent d319e60
commit 45a7a21
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/legacy/core_plugins/vis_type_vislib/public/components/options/metrics_axes/index.tsx b/src/legacy/core_plugins/vis_type_vislib/public/components/options/metrics_axes/index.tsx
@@ -92,14 +92,14 @@ function MetricsAxisOptions(props: ValidationVisOptionsProps<BasicVislibParams>)
   const updateAxisTitle = useCallback(
     (seriesParams?: SeriesParam[]) => {
       const series = seriesParams || stateParams.seriesParams;
-      const axes = cloneDeep(stateParams.valueAxes);
       let isAxesChanged = false;
       let lastValuesChanged = false;
       const lastLabels = { ...lastCustomLabels };
       const lastMatchingSeriesAgg = { ...lastSeriesAgg };
 
-      stateParams.valueAxes.forEach((axis, axisNumber) => {
+      const axes = stateParams.valueAxes.map((axis, axisNumber) => {
         let newCustomLabel = '';
+        let updatedAxis;
         const matchingSeries: IAggConfig[] = [];
 
         series.forEach((serie, seriesIndex) => {
@@ -135,16 +135,19 @@ function MetricsAxisOptions(props: ValidationVisOptionsProps<BasicVislibParams>)
             (aggTypeIsChanged ||
               aggFieldIsChanged ||
               axis.title.text === '' ||
-              lastCustomLabels[axis.id] === axis.title.text)
+              lastCustomLabels[axis.id] === axis.title.text) &&
+            newCustomLabel !== axis.title.text
           ) {
             // Override axis title with new custom label
-            axes[axisNumber] = {
+            updatedAxis = {
               ...axis,
               title: { ...axis.title, text: newCustomLabel },
             };
             isAxesChanged = true;
           }
         }
+
+        return updatedAxis || axis;
       });
 
       if (isAxesChanged) {