Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] New Platform server shim: update indices routes #57685

Merged
merged 3 commits into from
Feb 17, 2020
Merged

[ML] New Platform server shim: update indices routes #57685

merged 3 commits into from
Feb 17, 2020

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Feb 14, 2020 •
edited
Loading

Summary

Part of #49743.

Checklist

  • Documentation was added for features that require explanation or tutorials

@darnautov darnautov added :ml v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Feb 14, 2020
@darnautov darnautov requested a review from a team as a code owner February 14, 2020 13:30
@darnautov darnautov self-assigned this Feb 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

alvarezmelissa87
alvarezmelissa87 approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

peteharverson
peteharverson requested changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the route part of this is ok, but I am getting errors when using the View examples item in the anomalies table links menu ml\public\application\components\anomalies_table\links_menu.js viewExamples function that calls this route.

There are incorrect uses of this.props inside that function. I think it's worth fixing those in this PR too.

@jgowdyelastic
Copy link
Member

jgowdyelastic commented Feb 14, 2020 •
edited
Loading

There are incorrect uses of this.props inside that function. I think it's worth fixing those in this PR too.

it might be worth adding toasts and basePath to the class as they're used so much.

@darnautov
Copy link
Contributor Author

There are incorrect uses of this.props inside that function. I think it's worth fixing those in this PR too.

it might be worth adding toasts and basePath to the class as they're used so much.

actually basePath is used only once, toasts twice. I'd prefer to keep them in props and just change the error function to be an arrow one without context.

@darnautov darnautov force-pushed the ML-49743-indicesRoutes branch from 832aea9 to 93ed566 Compare February 15, 2020 13:46
@darnautov
Copy link
Contributor Author

I think the route part of this is ok, but I am getting errors when using the View examples item in the anomalies table links menu ml\public\application\components\anomalies_table\links_menu.js viewExamples function that calls this route.

There are incorrect uses of this.props inside that function. I think it's worth fixing those in this PR too.

Fixed in 93ed566

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

jgowdyelastic
jgowdyelastic approved these changes Feb 17, 2020
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@darnautov darnautov merged commit 84be262 into elastic:master Feb 17, 2020
@darnautov darnautov deleted the ML-49743-indicesRoutes branch February 17, 2020 09:59
@darnautov darnautov mentioned this pull request Feb 17, 2020
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request Feb 17, 2020
@darnautov
[ML] New Platform server shim: update indices routes (elastic#57685)
5f99fe4 
* [ML] NP indices routes

* [ML] fix error function

* [ML] fix createAndOpenUrl function
jloleysens added a commit to jloleysens/kibana that referenced this pull request Feb 17, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into console/featu…
2832bec 
…re/files-and-filetree

* 'master' of github.com:elastic/kibana: (139 commits)
  Move Ace XJSON lexer-rules, worker and utils to es_ui_shared (elastic#57563)
  [Upgrade Assistant] Fix filter deprecations search filter (elastic#57541)
  [ML] New Platform server shim: update indices routes (elastic#57685)
  Bump redux dependencies (elastic#53348)
  [Index management] Client-side NP ready (elastic#57295)
  change id of x-pack event_log plugin to eventLog (elastic#57612)
  [eventLog] get kibana.index name from config instead of hard-coding it (elastic#57607)
  revert
  allow using any path to generate
  fixes ui titles (elastic#57535)
  Fix login redirect for expired sessions (elastic#57157)
  Expose Vis on the contract as it requires visTypes (elastic#56968)
  [SIEM][Detection Engine] Fixes queries to ignore errors when signals index is not present
  [Remote clusters] Migrate client-side code out of legacy (elastic#57365)
  Fix failed test reporter for SIEM Cypress use (elastic#57240)
  skip flaky suite (elastic#45244)
  update chromedriver to 80.0.1 (elastic#57602)
  change slack action to only report on whitelisted host name (elastic#57582)
  [kbn/optimizer] throw errors into stream on invalid completion (elastic#57735)
  moving visualize/utils to new platform (elastic#56650)
  ...
darnautov added a commit that referenced this pull request Feb 21, 2020
@darnautov @elasticmachine
[ML] New Platform server shim: update indices routes (#57685) (#57778)
ac01660 
* [ML] NP indices routes

* [ML] fix error function

* [ML] fix createAndOpenUrl function

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@peteharverson peteharverson Awaiting requested review from peteharverson

Assignees

@darnautov darnautov

Labels
:ml release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@darnautov @elasticmachine @jgowdyelastic @kibanamachine @alvarezmelissa87 @peteharverson