[Upgrade Assistant] Fix filter deprecations search filter #57541

jloleysens · 2020-02-13T09:21:28Z

Summary

Release Notes

Fixed an issue with filtering deprecations in Upgrade Assistant where invalid Regular Expressions would fail silently. The UI now reports the issue.

Screenshots

First iteration

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios

For maintainers

This was checked for breaking API changes and was labeled appropriately

Added validateRegExpString util

…her search filter behaviour, e.g. index management.

elasticmachine · 2020-02-13T09:21:31Z

Pinging @elastic/es-ui (Team:Elasticsearch UI)

cjcenizal · 2020-02-13T15:15:39Z

@jloleysens Inserting the callout below the search box throws it out of alignment with the controls on the right, which looks a little weird. I wonder if there's a solution to this that doesn't alter the layout? Maybe a red alert icon to the right of the search box, with a tooltip that explains the error in more detail?

jloleysens · 2020-02-13T15:34:13Z

@cjcenizal I think to keep in line with something like Index Management

We can just move the callout rendering location to below the controls?

cjcenizal · 2020-02-13T15:35:00Z

Good idea!

The previous callout layout looked off-center next to the controls in the table.

alisonelizabeth

LGTM. Thanks for fixing this and adding tests!

I left one nit about the text. I also had a couple comments around the code, but I see they relate to code that already existed, so feel free to ignore.

alisonelizabeth · 2020-02-13T17:31:52Z

...y/plugins/upgrade_assistant/public/np_ready/application/components/tabs/checkup/controls.tsx

+          <EuiFlexItem grow={true}>
+            <EuiFieldSearch
+              isInvalid={filterInvalid}
+              aria-label="Filter"


alisonelizabeth · 2020-02-13T17:32:10Z

...y/plugins/upgrade_assistant/public/np_ready/application/components/tabs/checkup/controls.tsx

+            <EuiFieldSearch
+              isInvalid={filterInvalid}
+              aria-label="Filter"
+              placeholder={intl.formatMessage({


can you switch to i18n.translate() here instead?

alisonelizabeth · 2020-02-13T17:33:09Z

...y/plugins/upgrade_assistant/public/np_ready/application/components/tabs/checkup/controls.tsx

+    <EuiFlexGroup direction="column" responsive={false}>
+      <EuiFlexItem grow={true}>
+        <EuiFlexGroup alignItems="center" wrap={true} responsive={false}>
+          <EuiFlexItem grow={true}>


I believe true is the default

alisonelizabeth · 2020-02-13T17:34:55Z

...y/plugins/upgrade_assistant/public/np_ready/application/components/tabs/checkup/controls.tsx

+            title={i18n.translate(
+              'xpack.upgradeAssistant.checkupTab.controls.filterErrorMessageLabel',
+              {
+                defaultMessage: 'Filter Invalid: {searchTermError}',


nit: this should probably be sentence case per https://elastic.github.io/eui/#/guidelines/writing.

Update "Filter Invalid:" to sentence case Remove inject intl wrapper from CheckupControls component Remove unnecessary grow={true}

jloleysens · 2020-02-14T11:42:32Z

@elasticmachine merge upstream

jloleysens · 2020-02-17T08:05:43Z

@elasticmachine merge upstream

kibanamachine · 2020-02-17T09:45:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 855dae4

History

💚 Build #26797 succeeded 084f40d
💔 Build #26769 failed 21abaa0
💔 Build #26762 failed 518d010
💚 Build #26547 succeeded b4cdaf0
💚 Build #26491 succeeded f6aced9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

) * Made eui search field not a controlled component Added validateRegExpString util * Update error message display. Use EuiCallOut and i18n to replicate other search filter behaviour, e.g. index management. * Remove unused variable * Update Jest snapshot * Updated layout for callout The previous callout layout looked off-center next to the controls in the table. * Update copy and remove intl Update "Filter Invalid:" to sentence case Remove inject intl wrapper from CheckupControls component Remove unnecessary grow={true} * Updated Jest component snapshot Co-authored-by: Elastic Machine <[email protected]>

…re/files-and-filetree * 'master' of github.com:elastic/kibana: (139 commits) Move Ace XJSON lexer-rules, worker and utils to es_ui_shared (elastic#57563) [Upgrade Assistant] Fix filter deprecations search filter (elastic#57541) [ML] New Platform server shim: update indices routes (elastic#57685) Bump redux dependencies (elastic#53348) [Index management] Client-side NP ready (elastic#57295) change id of x-pack event_log plugin to eventLog (elastic#57612) [eventLog] get kibana.index name from config instead of hard-coding it (elastic#57607) revert allow using any path to generate fixes ui titles (elastic#57535) Fix login redirect for expired sessions (elastic#57157) Expose Vis on the contract as it requires visTypes (elastic#56968) [SIEM][Detection Engine] Fixes queries to ignore errors when signals index is not present [Remote clusters] Migrate client-side code out of legacy (elastic#57365) Fix failed test reporter for SIEM Cypress use (elastic#57240) skip flaky suite (elastic#45244) update chromedriver to 80.0.1 (elastic#57602) change slack action to only report on whitelisted host name (elastic#57582) [kbn/optimizer] throw errors into stream on invalid completion (elastic#57735) moving visualize/utils to new platform (elastic#56650) ...

…57779) * Made eui search field not a controlled component Added validateRegExpString util * Update error message display. Use EuiCallOut and i18n to replicate other search filter behaviour, e.g. index management. * Remove unused variable * Update Jest snapshot * Updated layout for callout The previous callout layout looked off-center next to the controls in the table. * Update copy and remove intl Update "Filter Invalid:" to sentence case Remove inject intl wrapper from CheckupControls component Remove unnecessary grow={true} * Updated Jest component snapshot Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

…57780) * Made eui search field not a controlled component Added validateRegExpString util * Update error message display. Use EuiCallOut and i18n to replicate other search filter behaviour, e.g. index management. * Remove unused variable * Update Jest snapshot * Updated layout for callout The previous callout layout looked off-center next to the controls in the table. * Update copy and remove intl Update "Filter Invalid:" to sentence case Remove inject intl wrapper from CheckupControls component Remove unnecessary grow={true} * Updated Jest component snapshot Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>

jloleysens added 3 commits February 12, 2020 18:31

Made eui search field not a controlled component

850459f

Added validateRegExpString util

Update error message display. Use EuiCallOut and i18n to replicate ot…

64e5478

…her search filter behaviour, e.g. index management.

Remove unused variable

3f8f45e

jloleysens added release_note:fix v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Upgrade Assistant v7.7.0 v7.6.1 labels Feb 13, 2020

jloleysens requested a review from alisonelizabeth February 13, 2020 09:21

Update Jest snapshot

f6aced9

Updated layout for callout

b4cdaf0

The previous callout layout looked off-center next to the controls in the table.

alisonelizabeth approved these changes Feb 13, 2020

View reviewed changes

jloleysens added 2 commits February 14, 2020 10:08

Update copy and remove intl

518d010

Update "Filter Invalid:" to sentence case Remove inject intl wrapper from CheckupControls component Remove unnecessary grow={true}

Updated Jest component snapshot

21abaa0

Merge branch 'master' into fix/ua/search-filter

084f40d

Merge branch 'master' into fix/ua/search-filter

855dae4

jloleysens merged commit 26fdc4a into elastic:master Feb 17, 2020

jloleysens deleted the fix/ua/search-filter branch February 17, 2020 10:04

jloleysens mentioned this pull request Feb 17, 2020

[7.x] [Upgrade Assistant] Fix filter deprecations search filter (#57541) #57779

Merged

jloleysens mentioned this pull request Feb 17, 2020

[7.6] [Upgrade Assistant] Fix filter deprecations search filter (#57541) #57780

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Upgrade Assistant] Fix filter deprecations search filter #57541

[Upgrade Assistant] Fix filter deprecations search filter #57541

jloleysens commented Feb 13, 2020 •

edited

Loading

elasticmachine commented Feb 13, 2020

cjcenizal commented Feb 13, 2020

jloleysens commented Feb 13, 2020

cjcenizal commented Feb 13, 2020

alisonelizabeth left a comment

alisonelizabeth Feb 13, 2020

alisonelizabeth Feb 13, 2020

alisonelizabeth Feb 13, 2020

alisonelizabeth Feb 13, 2020

jloleysens commented Feb 14, 2020

jloleysens commented Feb 17, 2020

kibanamachine commented Feb 17, 2020

[Upgrade Assistant] Fix filter deprecations search filter #57541

[Upgrade Assistant] Fix filter deprecations search filter #57541

Conversation

jloleysens commented Feb 13, 2020 • edited Loading

Summary

Release Notes

Screenshots

Checklist

For maintainers

elasticmachine commented Feb 13, 2020

cjcenizal commented Feb 13, 2020

jloleysens commented Feb 13, 2020

cjcenizal commented Feb 13, 2020

alisonelizabeth left a comment

Choose a reason for hiding this comment

alisonelizabeth Feb 13, 2020

Choose a reason for hiding this comment

alisonelizabeth Feb 13, 2020

Choose a reason for hiding this comment

alisonelizabeth Feb 13, 2020

Choose a reason for hiding this comment

alisonelizabeth Feb 13, 2020

Choose a reason for hiding this comment

jloleysens commented Feb 14, 2020

jloleysens commented Feb 17, 2020

kibanamachine commented Feb 17, 2020

💚 Build Succeeded

History

jloleysens commented Feb 13, 2020 •

edited

Loading