Ui Actions explorer example #57006
Merged
Ui Actions explorer example #57006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
stacey-gammon
added
v7.7.0
release_note:skip
stacey-gammon
force-pushed
the
2019-12-12-ui-actions-explorer
branch
from
8c40dc8 to
4b5ebcd
Compare
💔 Build Failed
To update your PR or re-run it, just comment with: |
stacey-gammon
force-pushed
the
2019-12-12-ui-actions-explorer
branch
from
4b5ebcd to
1987a23
Compare
stacey-gammon
force-pushed
the
2019-12-12-ui-actions-explorer
branch
from
1987a23 to
874ea11
Compare
💔 Build Failed
History
To update your PR or re-run it, just comment with: |
|
@elasticmachine merge upstream |
ppisljar
reviewed
Feb 10, 2020
| ); | ||
| }, | ||
| }); | ||
| uiActionsApi.registerAction(dynamicAction); |
There was a problem hiding this comment.
should we be cleaning this up somewhere ?
There was a problem hiding this comment.
No, I don't think so, though a page refresh will remove the dynamically added actions. I added a note in the success callout:
Refresh the page to reset state. It's up to the user of the system to persist state like this.
streamich
approved these changes
Feb 10, 2020
Comment on lines
75
to
80
| deps.uiActions.registerAction(createPhoneUserAction(depsStart.uiActions)); | ||
| deps.uiActions.registerAction(lookUpWeatherAction); | ||
| deps.uiActions.registerAction(viewInMapsAction); | ||
| deps.uiActions.registerAction(createEditUserAction(coreStart.overlays.openModal)); | ||
| deps.uiActions.registerAction(makePhoneCallAction); | ||
| deps.uiActions.registerAction(showcasePluggability); |
There was a problem hiding this comment.
Shall we register these in start life-cycle, or even better, in setup life-cycle?
There was a problem hiding this comment.
Moved what I could to setup, rest in start, a couple needed some start context.
There was a problem hiding this comment.
Not in this PR, but in general, should we register everything in setup life-cycles? As that was the idea for the setup life-cycle. For example, if something needs start life-cycle contracts we can pass in the promise:
setup(core) {
const start = core.getStartServices();
deps.uiActions.registerAction(createPhoneUserAction(start));
}There was a problem hiding this comment.
Yes! Thanks, updated in this PR.
stacey-gammon
force-pushed
the
2019-12-12-ui-actions-explorer
branch
from
559ba88 to
74c3a11
Compare
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
stacey-gammon
added a commit
to stacey-gammon/kibana
that referenced
this pull request
Feb 11, 2020
* wip * Move action registration out of AppMountContext fn * Move all registration to setup * Fix type error
stacey-gammon
added a commit
that referenced
this pull request
Feb 11, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 11, 2020
* master: (27 commits) Include actions new platform plugin for codeowners (elastic#57252) [APM][docs] 7.6 documentation updates (elastic#57124) Expressions refactor (elastic#54342) [ML] New Platform server shim: update annotation routes to use new platform router (elastic#57067) Remove injected ui app vars from Canvas (elastic#56190) update max_anomaly_score route schema to handle possible undefined values (elastic#57339) [Add panel flyout] Moving create new to the top of SavedObjectFinder (elastic#56428) Add mock of a legacy ui api to re-enable Canvas storybook (elastic#56673) [monitoring] Removes noisy event received log (elastic#57275) Remove use of copied MANAGEMENT_BREADCRUMBS and use `setBreadcrumbs` from management section's mount (elastic#57324) Advanced Settings management app to kibana platform plugin (elastic#56931) [ML] New Platform server shim: update recognize modules routes to use new platform router (elastic#57206) [ML] Fix overall stats for saved search on the Data Visualizer page (elastic#57312) [ML] [NP] Removing ui imports (elastic#56358) [SIEM] Fixes failing Cypress tests (elastic#57202) Create observability CODEOWNERS reference (elastic#57109) fix results service schema (elastic#57217) don't register a wrapper if browser side function exists. (elastic#57196) Ui Actions explorer example (elastic#57006) Fix update alert API to still work when AAD is out of sync (elastic#57039) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ui actions examples.
Default hello world trigger and action.
Ability to dynamically add new ones to highlight the context menu:
Newly added, triggers with context. Highlights the issue with nested
executeTriggerContextcalls. Types could really be improved here too, no type checking that the context emitted by the trigger and that needed by the action match up.