[ML] [NP] Removing ui imports #56358

jgowdyelastic · 2020-01-30T09:49:14Z

Removed all imports from 'ui/...'
Makes use of the kibana context where possible. For utility functions which are non-react, a cache of imported dependencies has been added. These are cleared when the app is closed using onAppLeave
Removes the use of injectI18n for translations.
Uses withKibana for components which can't use useMlKibana hook.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
~~- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~- [ ] Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~- [ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
~~- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately~~

jgowdyelastic · 2020-02-03T13:57:36Z

retest

elasticmachine · 2020-02-06T19:36:11Z

Pinging @elastic/ml-ui (:ml)

elasticmachine · 2020-02-06T19:58:31Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 0d1500ef621dfb5d7555f4aa70bc8e3149fac051

History

💔 Build #24887 failed 4088397e377a4fe4c1c74a5d5e5dd96bd32a26d5
💔 Build #24876 failed a44e3639f8be4e01e40a570b15613b3ad7787682
💚 Build #24344 succeeded 7963cd9665a8dd8e5e318f0a0e540bffa1201ada
💚 Build #24298 succeeded e2f96a12055960c7b5ef80f50423863c3b0f041a
💔 Build #24274 failed 20748f95d6ad43fe256df91e4a7cd34bca59e87b

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2020-02-06T20:59:38Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: b8f61d62b1c140a3f4cdea22f97a2bbbee51cd70

History

💔 Build #25011 failed 0d1500ef621dfb5d7555f4aa70bc8e3149fac051
💔 Build #24887 failed 4088397e377a4fe4c1c74a5d5e5dd96bd32a26d5
💔 Build #24876 failed a44e3639f8be4e01e40a570b15613b3ad7787682
💚 Build #24344 succeeded 7963cd9665a8dd8e5e318f0a0e540bffa1201ada
💚 Build #24298 succeeded e2f96a12055960c7b5ef80f50423863c3b0f041a

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2020-02-06T22:25:00Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d36fda38721403d35f48d47d5e9c73a9c6aafe9a

History

💔 Build #25036 failed b8f61d62b1c140a3f4cdea22f97a2bbbee51cd70
💔 Build #25011 failed 0d1500ef621dfb5d7555f4aa70bc8e3149fac051
💔 Build #24887 failed 4088397e377a4fe4c1c74a5d5e5dd96bd32a26d5
💔 Build #24876 failed a44e3639f8be4e01e40a570b15613b3ad7787682
💚 Build #24344 succeeded 7963cd9665a8dd8e5e318f0a0e540bffa1201ada

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2020-02-07T12:17:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: c579c42ae054fdee89980ad62547db81d855f2dd

History

💚 Build #25075 succeeded d36fda38721403d35f48d47d5e9c73a9c6aafe9a
💔 Build #25036 failed b8f61d62b1c140a3f4cdea22f97a2bbbee51cd70
💔 Build #25011 failed 0d1500ef621dfb5d7555f4aa70bc8e3149fac051
💔 Build #24887 failed 4088397e377a4fe4c1c74a5d5e5dd96bd32a26d5
💔 Build #24876 failed a44e3639f8be4e01e40a570b15613b3ad7787682

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

.../plugins/ml/public/application/components/annotations/annotations_table/annotations_table.js

...ugins/ml/public/application/components/full_time_range_selector/full_time_range_selector.tsx

x-pack/legacy/plugins/ml/public/application/hacks/toggle_app_link_in_nav.js

peteharverson · 2020-02-07T14:34:54Z

...ck/legacy/plugins/ml/public/application/jobs/jobs_list/components/job_details/job_details.js

              defaultMessage: 'Forecasts',
            }),
            content: <ForecastsTable job={job} />,
          }
        );
      }

-      if (mlAnnotationsEnabled && showFullDetails) {
+      if (showFullDetails) {


Is the mlAnnotationsEnabled check not needed any more?

as part of this work i removed the mlAnnotationsEnabled flag.
it was originally being set on the server from a constant value that never changed from being true.
it was then being imported using a chrome function that needed to be removed.
I discussed with @walterra and we agreed that it was redundant code that could be removed.

...acy/plugins/ml/public/application/jobs/jobs_list/components/jobs_list_view/jobs_list_view.js

x-pack/legacy/plugins/ml/public/application/routing/routes/new_job/wizard.tsx

x-pack/legacy/plugins/ml/public/application/util/dependency_cache.ts

peteharverson · 2020-02-07T16:10:13Z

...plugins/ml/public/application/jobs/jobs_list/components/delete_job_modal/delete_job_modal.js

+import { i18n } from '@kbn/i18n';
+import { FormattedMessage } from '@kbn/i18n/react';
+
+export class DeleteJobModal extends Component {


I see this console warning when deleting a job. Is it related to your changes?

I see this on master also. So not a new warning

peteharverson · 2020-02-10T12:22:06Z

If I try and access the Jobs List from the Management page, I see this error, and the jobs list fails to display:

darnautov

LGTM

kibanamachine · 2020-02-11T15:59:10Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 7f0ae9e

History

💔 Build #25853 failed 864d199
💚 Build #25575 succeeded 4a22fc0f812f9073ba19ede3d2d454132c9bd92f
💚 Build #25454 succeeded 70b18a89b11c5c5043b4ec291e41179e9a46fda7
💚 Build #25322 succeeded c6f86aca1c56ca9a5c761932a0cc57e6d4b3b006
💚 Build #25292 succeeded 4994c9082029ab0c7265240639bdedd5bcd902e7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [ML] [NP] Removing ui imports * replacing timefilter and ui context * replacing ui/i18n and ui/metadata * removing ui/system_api * removing ui/notify * removing most ui/new_platform * fix explorer date format loading * removing ui/chrome * fixing timebuckets test * fixing jest tests * adding http * testing odd CI type failure * revrting type test changes * fixing odd test type error * refactoring dependencies * removing injectI18n and using withKibana for context * updating components to use kibana context * re-enabling some tests * fixing translation strings * adding comments * removing commented out code * missing i18n * fixing rebase conflicts * removing unused ui contexts * changes based on review * adding text to errors * fixing management plugin * changes based on review * refeactor after rebase * fixing test

* master: (27 commits) Include actions new platform plugin for codeowners (elastic#57252) [APM][docs] 7.6 documentation updates (elastic#57124) Expressions refactor (elastic#54342) [ML] New Platform server shim: update annotation routes to use new platform router (elastic#57067) Remove injected ui app vars from Canvas (elastic#56190) update max_anomaly_score route schema to handle possible undefined values (elastic#57339) [Add panel flyout] Moving create new to the top of SavedObjectFinder (elastic#56428) Add mock of a legacy ui api to re-enable Canvas storybook (elastic#56673) [monitoring] Removes noisy event received log (elastic#57275) Remove use of copied MANAGEMENT_BREADCRUMBS and use `setBreadcrumbs` from management section's mount (elastic#57324) Advanced Settings management app to kibana platform plugin (elastic#56931) [ML] New Platform server shim: update recognize modules routes to use new platform router (elastic#57206) [ML] Fix overall stats for saved search on the Data Visualizer page (elastic#57312) [ML] [NP] Removing ui imports (elastic#56358) [SIEM] Fixes failing Cypress tests (elastic#57202) Create observability CODEOWNERS reference (elastic#57109) fix results service schema (elastic#57217) don't register a wrapper if browser side function exists. (elastic#57196) Ui Actions explorer example (elastic#57006) Fix update alert API to still work when AAD is out of sync (elastic#57039) ...

Fixes a regression introduced by #56358. We're reusing the KqlFilterBar from the ML plugin in the transform plugin and missed updating the dependency management. Note this PR is only about fixing that regression. Future work on NP migration should take care of cleaning up the dependency management in the transforms plugin in general.

Fixes a regression introduced by elastic#56358. We're reusing the KqlFilterBar from the ML plugin in the transform plugin and missed updating the dependency management. Note this PR is only about fixing that regression. Future work on NP migration should take care of cleaning up the dependency management in the transforms plugin in general.

…7852) Fixes a regression introduced by #56358. We're reusing the KqlFilterBar from the ML plugin in the transform plugin and missed updating the dependency management. Note this PR is only about fixing that regression. Future work on NP migration should take care of cleaning up the dependency management in the transforms plugin in general.

jgowdyelastic force-pushed the ml-np-removing-ui-imports branch 2 times, most recently from 9682027 to b47cee3 Compare February 3, 2020 10:59

jgowdyelastic force-pushed the ml-np-removing-ui-imports branch from a44e363 to 4088397 Compare February 6, 2020 12:17

jgowdyelastic marked this pull request as ready for review February 6, 2020 19:35

jgowdyelastic requested a review from a team as a code owner February 6, 2020 19:35

jgowdyelastic requested review from peteharverson, walterra, darnautov and alvarezmelissa87 February 6, 2020 19:35

jgowdyelastic self-assigned this Feb 6, 2020

jgowdyelastic added :ml Feature:New Platform non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.7.0 v8.0.0 labels Feb 6, 2020

elastic deleted a comment from kibanamachine Feb 6, 2020

jgowdyelastic force-pushed the ml-np-removing-ui-imports branch from a05ea62 to 286d559 Compare February 6, 2020 20:50

peteharverson reviewed Feb 7, 2020

View reviewed changes

jgowdyelastic force-pushed the ml-np-removing-ui-imports branch 2 times, most recently from 76e7a27 to 70b18a8 Compare February 9, 2020 21:14

jgowdyelastic added 13 commits February 11, 2020 12:59

removing injectI18n and using withKibana for context

3f8a4d6

updating components to use kibana context

6f76501

re-enabling some tests

d0a56e4

fixing translation strings

d150430

adding comments

ed51a2f

removing commented out code

3244480

missing i18n

f0f2786

fixing rebase conflicts

87af784

removing unused ui contexts

0689e3f

changes based on review

e301751

adding text to errors

2c76e01

fixing management plugin

eed8c87

changes based on review

8464f2a

jgowdyelastic force-pushed the ml-np-removing-ui-imports branch from 36dd3eb to 8464f2a Compare February 11, 2020 13:00

refeactor after rebase

864d199

darnautov approved these changes Feb 11, 2020

View reviewed changes

fixing test

7f0ae9e

jgowdyelastic merged commit b3e8bdf into elastic:master Feb 11, 2020

jgowdyelastic mentioned this pull request Feb 11, 2020

[7.x] [ML] [NP] Removing ui imports (#56358) #57336

Merged

jgowdyelastic deleted the ml-np-removing-ui-imports branch February 11, 2020 16:19

jgowdyelastic mentioned this pull request Feb 11, 2020

[ML] Removing missed timefilter include #57373

Merged

alexwizp mentioned this pull request Feb 12, 2020

fix Master branch #57421

Merged

7 tasks

walterra mentioned this pull request Feb 18, 2020

[ML] Transform: Fix transform wizard query autocomplete. #57833

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] [NP] Removing ui imports #56358

[ML] [NP] Removing ui imports #56358

jgowdyelastic commented Jan 30, 2020 •

edited

Loading

jgowdyelastic commented Feb 3, 2020

elasticmachine commented Feb 6, 2020

elasticmachine commented Feb 6, 2020

elasticmachine commented Feb 6, 2020

elasticmachine commented Feb 6, 2020

elasticmachine commented Feb 7, 2020

peteharverson Feb 7, 2020

jgowdyelastic Feb 7, 2020 •

edited

Loading

peteharverson Feb 7, 2020

jgowdyelastic Feb 7, 2020

peteharverson commented Feb 10, 2020

darnautov left a comment

kibanamachine commented Feb 11, 2020

[ML] [NP] Removing ui imports #56358

[ML] [NP] Removing ui imports #56358

Conversation

jgowdyelastic commented Jan 30, 2020 • edited Loading

Checklist

For maintainers

jgowdyelastic commented Feb 3, 2020

elasticmachine commented Feb 6, 2020

elasticmachine commented Feb 6, 2020

💔 Build Failed

History

elasticmachine commented Feb 6, 2020

💔 Build Failed

History

elasticmachine commented Feb 6, 2020

💚 Build Succeeded

History

elasticmachine commented Feb 7, 2020

💚 Build Succeeded

History

peteharverson Feb 7, 2020

Choose a reason for hiding this comment

jgowdyelastic Feb 7, 2020 • edited Loading

Choose a reason for hiding this comment

peteharverson Feb 7, 2020

Choose a reason for hiding this comment

jgowdyelastic Feb 7, 2020

Choose a reason for hiding this comment

peteharverson commented Feb 10, 2020

darnautov left a comment

Choose a reason for hiding this comment

kibanamachine commented Feb 11, 2020

💚 Build Succeeded

History

jgowdyelastic commented Jan 30, 2020 •

edited

Loading

jgowdyelastic Feb 7, 2020 •

edited

Loading