Abort cancelled search requests to Elasticsearch #56788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasolson
added
Feature:Search
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
jbudz
reviewed
Feb 4, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Feb 10, 2020
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
streamich
approved these changes
Feb 24, 2020
| @@ -47,7 +47,7 @@ export const syncSearchStrategyProvider: TSearchStrategyProvider<typeof SYNC_SEA | |||
| signal: options.signal, | |||
| }); | |||
|
|
|||
| response.then(() => loadingCount$.next(loadingCount$.getValue() - 1)); | |||
| response.finally(() => loadingCount$.next(loadingCount$.getValue() - 1)); | |||
There was a problem hiding this comment.
Curious, if this is a bug fix and if there should be a test case for this?
There was a problem hiding this comment.
Yes it is and yes there should be.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Feb 25, 2020
* Update abort controller library * Bootstrap * Abort when the request is aborted * Add utility and update value suggestions route * Remove bad merge * Revert switching abort controller libraries * Revert package.json in lib * Move to previous abort controller * Fix test to use fake timers to run debounced handlers * Fix loading bar not going away when cancelling * Add test for loading count * Fix test * Fix failing test Co-authored-by: Elastic Machine <[email protected]>
|
7.x (7.7.0): b35f969 |
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kibanamachine
added
the
backport missing
kibanamachine
removed
the
backport missing
lukasolson
added a commit
to lukasolson/kibana
that referenced
this pull request
Feb 28, 2020
* Update abort controller library * Bootstrap * Abort when the request is aborted * Add utility and update value suggestions route * Remove bad merge * Revert switching abort controller libraries * Revert package.json in lib * Move to previous abort controller * Fix test to use fake timers to run debounced handlers * Fix loading bar not going away when cancelling * Add test for loading count * Fix test * Fix failing test Co-authored-by: Elastic Machine <[email protected]>
lukasolson
added a commit
that referenced
this pull request
Feb 28, 2020
* Abort cancelled search requests to Elasticsearch (#56788) * Update abort controller library * Bootstrap * Abort when the request is aborted * Add utility and update value suggestions route * Remove bad merge * Revert switching abort controller libraries * Revert package.json in lib * Move to previous abort controller * Fix test to use fake timers to run debounced handlers * Fix loading bar not going away when cancelling * Add test for loading count * Fix test * Fix failing test Co-authored-by: Elastic Machine <[email protected]> * Remove unnecessary tests Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #55490.
Since the search service and KQL value suggestions were moved to the new platform, there had previously been no way in a route handler to listen for when a request was disconnected. This functionality has since been added. Following this PR, search requests (using the search service or KQL value suggestions) that initiate client-side that are disconnected will now close the upstream connection to Elasticsearch. This signals Elasticsearch to clean up any tasks associated with the originating search request.
Checklist
For maintainers