Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Blocker] KQL Autocomplete chokes ES #58749

Closed
lizozom opened this issue Feb 27, 2020 · 3 comments · Fixed by #58784
Closed

[Blocker] KQL Autocomplete chokes ES #58749

lizozom opened this issue Feb 27, 2020 · 3 comments · Fixed by #58784
Assignees
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:KQL KQL Feature:New Platform v7.6.1

Comments

@lizozom
Copy link
Contributor

lizozom commented Feb 27, 2020

Kibana version:
7.6, 7.6.1, 8.0

Elasticsearch version:

Server OS version:

Browser version:

Browser OS version:

Original install method (e.g. download page, yum, from source, etc.):

Describe the bug:
This bug is a combination of several issues:

  1. This pr accidentally removed the timeout from the autocomplete request making the autocomplete requests run without a timeout (combination of dropping the ms suffix from timeout and fetching the config from the wrong place, resulting in an undefined timeout being sent to ES.

  2. This pr introduced query cancellation, but the query wasn't actually canceled on the server until 7.7 Abort cancelled search requests to Elasticsearch #56788

Together, these two issues cause ES to get to 100% CPU in a production environment, making it almost unusable unless KQL autocomplete is disabled.

Steps to reproduce:

  1. Run kibana in verbose mode
elasticsearch.logQueries: true 
logging.verbose: true 
  1. Type a KQL query into the query bar.
  2. Find the request sent to ES in the console. it should have had timeout and terminate_after, but it doesn't.

Expected behavior:
All requests should have timeout and terminate_after

Screenshots (if relevant):

Errors in browser console (if relevant):

Provide logs and/or server output (if relevant):

Any additional context:

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@BobBlank12
Copy link

Is setting: kuery_autocomplete.enabled: false a valid workaround until the fix is released?

@lizozom
Copy link
Contributor Author

lizozom commented Mar 3, 2020

@BobBlank12 indeed. It should eliminate the problematic behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker bug Fixes for quality problems that affect the customer experience Feature:KQL KQL Feature:New Platform v7.6.1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants