-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the editor config provider registry #56501
Remove the editor config provider registry #56501
Conversation
|
||
export interface TypeMeta { | ||
aggs?: Record<string, AggregationRestrictions>; | ||
params?: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can make that even softer and allow
export interface TypeMeta {
aggs?: Record<string, AggregationRestrictions>;
[key: string]: any;
}
It's not the case for current usages, but theoretically a plugin could put other stuff in here
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested and restrictions work as expected in editor
Pinging @elastic/kibana-app (Team:KibanaApp) |
…fig_provider # Conflicts: # src/legacy/core_plugins/vis_default_editor/public/components/agg_param_props.ts # src/legacy/core_plugins/vis_default_editor/public/components/agg_params.tsx # src/legacy/core_plugins/vis_default_editor/public/components/agg_params_helper.test.ts # src/legacy/core_plugins/vis_default_editor/public/components/agg_params_helper.ts # src/legacy/core_plugins/vis_default_editor/public/components/controls/test_utils.ts # src/legacy/ui/public/vis/config/editor_config_providers.test.ts # src/legacy/ui/public/vis/config/editor_config_providers.ts # x-pack/legacy/plugins/rollup/public/legacy.ts # x-pack/legacy/plugins/rollup/public/legacy_imports.ts
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* Remove the editor_config_providers * Remove unused translations * Fix eslint errors Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # src/plugins/data/public/index_patterns/index_patterns/index_pattern.tsx
Summary
This removes the
editorConfigProviders
which was only working for rollup indexes.Instead, the
getAggregationRestrictions
was created in theindexPattern
instance to retrieve those restrictions without relying on therollup
index type.Also resolves #55970.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers