Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the editor config provider registry #56501

Merged
merged 5 commits into from
Feb 5, 2020

Conversation

sulemanof
Copy link
Contributor

Summary

This removes the editorConfigProviders which was only working for rollup indexes.
Instead, the getAggregationRestrictions was created in the indexPattern instance to retrieve those restrictions without relying on the rollup index type.

Also resolves #55970.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@sulemanof sulemanof requested a review from flash1293 January 31, 2020 15:22

export interface TypeMeta {
aggs?: Record<string, AggregationRestrictions>;
params?: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can make that even softer and allow

export interface TypeMeta {
  aggs?: Record<string, AggregationRestrictions>;
  [key: string]: any;
}

It's not the case for current usages, but theoretically a plugin could put other stuff in here

@sulemanof sulemanof marked this pull request as ready for review February 3, 2020 13:16
@sulemanof sulemanof requested a review from a team February 3, 2020 13:16
@sulemanof sulemanof requested a review from a team as a code owner February 3, 2020 13:16
@sulemanof
Copy link
Contributor Author

@elasticmachine merge upstream

@sulemanof sulemanof added v7.7.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Feb 3, 2020
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested and restrictions work as expected in editor

@flash1293 flash1293 added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Feb 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 added Feature:NP Migration Feature:Vis Editor Visualization editor issues labels Feb 5, 2020
…fig_provider

# Conflicts:
#	src/legacy/core_plugins/vis_default_editor/public/components/agg_param_props.ts
#	src/legacy/core_plugins/vis_default_editor/public/components/agg_params.tsx
#	src/legacy/core_plugins/vis_default_editor/public/components/agg_params_helper.test.ts
#	src/legacy/core_plugins/vis_default_editor/public/components/agg_params_helper.ts
#	src/legacy/core_plugins/vis_default_editor/public/components/controls/test_utils.ts
#	src/legacy/ui/public/vis/config/editor_config_providers.test.ts
#	src/legacy/ui/public/vis/config/editor_config_providers.ts
#	x-pack/legacy/plugins/rollup/public/legacy.ts
#	x-pack/legacy/plugins/rollup/public/legacy_imports.ts
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof merged commit 367086b into elastic:master Feb 5, 2020
@sulemanof sulemanof deleted the remove_editor_config_provider branch February 5, 2020 14:25
sulemanof added a commit that referenced this pull request Feb 5, 2020
* Remove the editor_config_providers

* Remove unused translations

* Fix eslint errors

Co-authored-by: Elastic Machine <[email protected]>

# Conflicts:
#	src/plugins/data/public/index_patterns/index_patterns/index_pattern.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported Feature:NP Migration Feature:Vis Editor Visualization editor issues release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot change the interval of date histogram agg on Default Editor
5 participants