Fix date_histogram agg interval in rollup index #56022
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #55970.
The intention of the PR is to limit calls of functions in
editorConfig
providers registry via passing only necessary fields.This was broken because since the Reactifying of the default editor, every change in agg creates a new instance of the agg object, therefore the function, registered in
x-pack/legacy/plugins/rollup/public/visualize/editor_config.js
was called on every change and returned the default values (seems this should be done only once).The way of the fix - pass only necessary field to the editor_config registry. Besides that, I would look into refactoring code in
agg_params.tsx
&agg.tsx
files, to achieve more evidence in relationship between those, stability of work and I suppose to think better performance (reduce rendering params if agg type was not selected).Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers