Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix date_histogram agg interval in rollup index #56022

Closed
wants to merge 3 commits into from

Conversation

sulemanof
Copy link
Contributor

@sulemanof sulemanof commented Jan 27, 2020

Summary

Resolves #55970.

The intention of the PR is to limit calls of functions in editorConfig providers registry via passing only necessary fields.
This was broken because since the Reactifying of the default editor, every change in agg creates a new instance of the agg object, therefore the function, registered in x-pack/legacy/plugins/rollup/public/visualize/editor_config.js was called on every change and returned the default values (seems this should be done only once).

The way of the fix - pass only necessary field to the editor_config registry. Besides that, I would look into refactoring code in agg_params.tsx & agg.tsx files, to achieve more evidence in relationship between those, stability of work and I suppose to think better performance (reduce rendering params if agg type was not selected).

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@sulemanof sulemanof marked this pull request as ready for review January 28, 2020 06:47
@sulemanof sulemanof added release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0 labels Jan 28, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@sulemanof sulemanof closed this Jan 31, 2020
@sulemanof
Copy link
Contributor Author

Closed in favor of #56501

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot change the interval of date histogram agg on Default Editor
2 participants