Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Centralize advanced setting dirty state #55308

Closed

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Jan 20, 2020

Summary

Fixes #27405

Converts the contextual advanced settings menu to the global one:
Before:
image

After:
image

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@mbondyra mbondyra added v8.0.0 v7.7.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mbondyra mbondyra force-pushed the centralize-advanced-setting-dirty-state branch 3 times, most recently from 81cb86b to f5543e5 Compare January 23, 2020 11:51
@mbondyra mbondyra force-pushed the centralize-advanced-setting-dirty-state branch from f5543e5 to b178339 Compare January 23, 2020 16:04
@mbondyra mbondyra marked this pull request as ready for review January 23, 2020 16:52
@mbondyra mbondyra requested review from a team as code owners January 23, 2020 16:52
@elastic elastic deleted a comment from kibanamachine Jan 23, 2020
@mbondyra
Copy link
Contributor Author

closing as it's duplicate

@mbondyra mbondyra closed this Jan 23, 2020
@mbondyra mbondyra deleted the centralize-advanced-setting-dirty-state branch January 23, 2020 17:41
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Advanced Settings] Improve dirty state UI (save and cancel buttons)
3 participants