Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Advanced Settings] Improve dirty state UI (save and cancel buttons) #27405

Closed
cchaos opened this issue Dec 18, 2018 · 4 comments · Fixed by #53693
Closed

[Advanced Settings] Improve dirty state UI (save and cancel buttons) #27405

cchaos opened this issue Dec 18, 2018 · 4 comments · Fixed by #53693
Assignees
Labels
Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. usability

Comments

@cchaos
Copy link
Contributor

cchaos commented Dec 18, 2018

There are two problems that still needs to be solved on the Advanced Settings page.

  1. UX of saving individual settings. It's quite cumbersome for someone to want to change more than one setting at a time, but having to hit "Save" for each individual setting.
  2. UI for when the save/cancel buttons appear. When viewed at certain screen sizes, the appearance of the buttons causes the page to increase in width but not include any scrollbars and therefore can cut off the buttons entirely.


Suggested resolution

I highly suggest that we switch to using the EuiBottomBar that will contain a "Save" and "Cancel" button that will appear once any of the fields become "dirty" and will save or cancel all dirty stated fields at once.

This will fix both problems even allowing more horizontal space usage to the fields themselves.

Example:

screen shot 2018-12-18 at 11 21 59 am

@cchaos cchaos added Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. usability Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Dec 18, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design

@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app

@cjcenizal
Copy link
Contributor

FYI, this is outside of the Elasticsearch UI team's purview. We just work on the apps under the "Elasticsearch" section of Management, and Dev Tools.

@cjcenizal cjcenizal removed the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Dec 18, 2018
@lukeelmers lukeelmers added :AppArch and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Mar 27, 2019
@mbondyra mbondyra self-assigned this Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. usability
Projects
None yet
5 participants