Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Set filterByMapBounds to default constant if no arg passed #55068

Merged
merged 5 commits into from
Feb 4, 2020
Merged

[Maps] Set filterByMapBounds to default constant if no arg passed #55068

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a5aaf18
Set filterByMapBounds to default constant if no arg passed
Jan 16, 2020
a696dcc
Merge remote-tracking branch 'upstream/master' into fix-es-search-sou…
Feb 3, 2020
4d9e83c
toggle accidentally refers to props instead of state for filterByBoun…
Feb 4, 2020
d744b1e
Review feedback. Remove extra filterByMapBounds
Feb 4, 2020
c02f040
Merge branch 'master' into fix-es-search-source-filterbymapbounds-error
elasticmachine Feb 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion x-pack/legacy/plugins/maps/public/layers/sources/es_search_source/create_source_editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export class CreateSourceEditor extends Component {
state = {
isLoadingIndexPattern: false,
noGeoIndexPatternsExist: false,
filterByMapBounds: DEFAULT_FILTER_BY_MAP_BOUNDS,
kindsun marked this conversation as resolved.
Show resolved Hide resolved
...RESET_INDEX_PATTERN_STATE,
};

Expand Down Expand Up @@ -227,7 +228,7 @@ export class CreateSourceEditor extends Component {
label={i18n.translate('xpack.maps.source.esSearch.extentFilterLabel', {
defaultMessage: `Dynamically filter for data in the visible map area`,
})}
checked={this.props.filterByMapBounds}
checked={this.state.filterByMapBounds}
onChange={this.onFilterByMapBoundsChange}
/>
</EuiFormRow>
Expand Down