[Maps] Set filterByMapBounds to default constant if no arg passed #55068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kindsun
added
bug
|
Pinging @elastic/kibana-gis (Team:Geo) |
kindsun
added
the
release_note:skip
nreese
reviewed
Jan 16, 2020
There was a problem hiding this comment.
this component is actually broken as https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/maps/public/layers/sources/es_search_source/es_search_source.js#L57 never passes filterByMapBounds to the component, so its value is never updated in props.
The EuiSwitch checked property should be coming from this.state.filterByMapBounds instead of this.props.filterByMapBounds
added 2 commits
February 3, 2020 16:39
…rce-filterbymapbounds-error
…ds. update to state
nreese
reviewed
Feb 4, 2020
x-pack/legacy/plugins/maps/public/layers/sources/es_search_source/create_source_editor.js
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Feb 4, 2020
…astic#55068) * Set filterByMapBounds to default constant if no arg passed * toggle accidentally refers to props instead of state for filterByBounds. update to state * Review feedback. Remove extra filterByMapBounds Co-authored-by: Elastic Machine <[email protected]>
This was referenced Feb 4, 2020
kindsun
pushed a commit
to kindsun/kibana
that referenced
this pull request
Feb 4, 2020
…astic#55068) * Set filterByMapBounds to default constant if no arg passed * toggle accidentally refers to props instead of state for filterByBounds. update to state * Review feedback. Remove extra filterByMapBounds Co-authored-by: Elastic Machine <[email protected]>
kindsun
pushed a commit
that referenced
this pull request
Feb 4, 2020
…5068) (#56768) * Set filterByMapBounds to default constant if no arg passed * toggle accidentally refers to props instead of state for filterByBounds. update to state * Review feedback. Remove extra filterByMapBounds Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
kindsun
pushed a commit
that referenced
this pull request
Feb 5, 2020
…5068) (#56767) * Set filterByMapBounds to default constant if no arg passed * toggle accidentally refers to props instead of state for filterByBounds. update to state * Review feedback. Remove extra filterByMapBounds Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes/removes this error when adding an ES Search Source by setting
filterByMapBoundsto its default constant if no arg is passed to the component: