Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Make sure errors per minute are reported correctly #54751

Merged
merged 1 commit into from
Jan 14, 2020
Merged

[APM] Make sure errors per minute are reported correctly #54751

merged 1 commit into from
Jan 14, 2020

Conversation

dgieselaar
Copy link
Member

Closes #54350.

@dgieselaar dgieselaar requested a review from a team as a code owner January 14, 2020 15:59
cauemarcondes
cauemarcondes approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@cauemarcondes cauemarcondes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dgieselaar dgieselaar merged commit b91b123 into elastic:master Jan 14, 2020
@dgieselaar dgieselaar deleted the errors-zero branch January 14, 2020 20:34
@dgieselaar dgieselaar mentioned this pull request Jan 14, 2020
Merged
dgieselaar added a commit to dgieselaar/kibana that referenced this pull request Jan 14, 2020
@dgieselaar
[APM] Make sure errors per minute are reported correctly (elastic#54751)
4c42302 
Closes elastic#54350.
@ogupte ogupte added apm-test-plan-7.6.0 apm:test-plan-done Pull request that was successfully tested during the test plan labels Jan 15, 2020
@ogupte ogupte self-assigned this Jan 16, 2020
jkelastic pushed a commit to jkelastic/kibana that referenced this pull request Jan 17, 2020
@dgieselaar @jkelastic
[APM] Make sure errors per minute are reported correctly (elastic#54751)
b86cd71 
Closes elastic#54350.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cauemarcondes cauemarcondes cauemarcondes approved these changes

Assignees

@ogupte ogupte

Labels
apm:test-plan-done Pull request that was successfully tested during the test plan release_note:fix v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[APM] Errors could incorrectly report as 0/pm in services overview
4 participants
@dgieselaar @kibanamachine @cauemarcondes @ogupte