Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Errors could incorrectly report as 0/pm in services overview #54350

Closed
dgieselaar opened this issue Jan 9, 2020 · 1 comment · Fixed by #54751
Closed

[APM] Errors could incorrectly report as 0/pm in services overview #54350

dgieselaar opened this issue Jan 9, 2020 · 1 comment · Fixed by #54751
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.6.0

Comments

@dgieselaar
Copy link
Member

In the service overview list, we show the number of errors per minute. Because there's a size limit (2) on the terms aggregation, in some cases the service might report errors as 0 per minute because the term buckets cut off prematurely.

This might have been shipped in 7.5, so we need to investigate that as well.

Suggested fix: remove the size option in server/lib/services/get_services/get_services_items.ts.
@dgieselaar dgieselaar added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.6.0 labels Jan 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

dgieselaar added a commit to dgieselaar/kibana that referenced this issue Jan 14, 2020
@dgieselaar
[APM] Make sure errors per minute are reported correctly
3acb19c 
Closes elastic#54350.
@dgieselaar dgieselaar mentioned this issue Jan 14, 2020
Merged
dgieselaar added a commit that referenced this issue Jan 14, 2020
@dgieselaar
[APM] Make sure errors per minute are reported correctly (#54751)
b91b123 
Closes #54350.
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Jan 14, 2020
@dgieselaar
[APM] Make sure errors per minute are reported correctly (elastic#54751)
4c42302 
Closes elastic#54350.
dgieselaar added a commit that referenced this issue Jan 15, 2020
@dgieselaar
[7.x] [APM] Make sure errors per minute are reported correctly… (#54808)
02ec594 
Closes #54350.
jkelastic pushed a commit to jkelastic/kibana that referenced this issue Jan 17, 2020
@dgieselaar @jkelastic
[APM] Make sure errors per minute are reported correctly (elastic#54751)
b86cd71 
Closes elastic#54350.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Make sure errors per minute are reported correctly dgieselaar/kibana
2 participants
@dgieselaar @elasticmachine