Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Persist the time range brush when expanded to full width #54020

Merged
merged 1 commit into from
Jan 7, 2020
Merged

[ML] Persist the time range brush when expanded to full width #54020

merged 1 commit into from
Jan 7, 2020

Conversation

darnautov
Copy link
Contributor

Summary

Resolves #53462. Persist the time range brush on Single Metric Viewer when expanded to full width.

Jan-06-2020 16-25-01

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

@darnautov darnautov requested a review from a team as a code owner January 6, 2020 15:28
@darnautov darnautov self-assigned this Jan 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

alvarezmelissa87
alvarezmelissa87 approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

peteharverson
peteharverson reviewed Jan 6, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note you can still get to a situation where the brush is no longer visible by clicking outside the brush. We should consider whether we want to show a full width brush in this scenario too:

smv_brush

@pheyos
Copy link
Member

pheyos commented Jan 7, 2020

With the current state of this PR we're back at the 6.8 behavior, so #53462 is indeed resolved.
As @peteharverson mentioned, the brush goes away when clicking outside the selected area. But it comes back when dragging in the time slider area, which is kind of intuitive.
From my point of view usability would be even better when falling back to a full width brush in that scenario, but depending on how much work is needed to do that, I think the current solution could also stay.

peteharverson
peteharverson approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This restores the original behavior.

@darnautov darnautov merged commit 54b2f14 into elastic:master Jan 7, 2020
@darnautov darnautov deleted the ML-53462-persist-time-slider branch January 7, 2020 12:55
@darnautov darnautov mentioned this pull request Jan 7, 2020
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request Jan 7, 2020
@darnautov
[ML] persist the brush when expanded to full width (elastic#54020)
23848af
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 7, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/conso…
792771e 
…le-saved-objects

* 'master' of github.com:elastic/kibana: (86 commits)
  [Uptime] Added date range filter into expanded list query (elastic#52609)
  [SIEM] Add react/display-name eslint rule (elastic#53107)
  [SIEM] Enable eslint prefer-template rule (elastic#53983)
  Elasticsearch snapshots automation (elastic#53706)
  [SIEM] Enable eslint react/no-children-prop (elastic#53985)
  [DOCS][Reporting] Adds info about using a custom reporting index (elastic#54052)
  Changing background color to align with EUI color (elastic#54060)
  Fix linting issues (elastic#54068)
  NP Migration: Move doc views registry and existing doc views into discover plugin (elastic#53465)
  [ML] DF Analytics job creation: Add 'excludes' input field to form (elastic#53856)
  EMT-issue-65: add endpoint list api (elastic#53861)
  [SIEM] Fix doubled drag handles in Timeline (elastic#52679)
  Functional tests: refactor visualize_page (elastic#53845)
  [Dashboard] Redesign empty screen in readonly mode (elastic#54073)
  [ML] Support search for partitions on Single Metric Viewer (elastic#53879)
  update apm index pattern (elastic#54095)
  Add data ui for envoyproxy Metricbeat Module (elastic#53476)
  [ML] persist the brush when expanded to full width (elastic#54020)
  Skip failing test (elastic#54100)
  [APM] Show errors on the timeline instead of under the transaction (elastic#53756)
  ...

# Conflicts:
#	src/legacy/core_plugins/console/public/np_ready/application/contexts/services_context.tsx
#	src/legacy/core_plugins/console/public/np_ready/application/index.tsx
jloleysens added a commit to jloleysens/kibana that referenced this pull request Jan 7, 2020
@jloleysens
Merge branch 'feature/console-saved-objects' of github.com:jloleysens…
760d29f 
…/kibana into feature/console-saved-objects

* 'feature/console-saved-objects' of github.com:jloleysens/kibana: (86 commits)
  [Uptime] Added date range filter into expanded list query (elastic#52609)
  [SIEM] Add react/display-name eslint rule (elastic#53107)
  [SIEM] Enable eslint prefer-template rule (elastic#53983)
  Elasticsearch snapshots automation (elastic#53706)
  [SIEM] Enable eslint react/no-children-prop (elastic#53985)
  [DOCS][Reporting] Adds info about using a custom reporting index (elastic#54052)
  Changing background color to align with EUI color (elastic#54060)
  Fix linting issues (elastic#54068)
  NP Migration: Move doc views registry and existing doc views into discover plugin (elastic#53465)
  [ML] DF Analytics job creation: Add 'excludes' input field to form (elastic#53856)
  EMT-issue-65: add endpoint list api (elastic#53861)
  [SIEM] Fix doubled drag handles in Timeline (elastic#52679)
  Functional tests: refactor visualize_page (elastic#53845)
  [Dashboard] Redesign empty screen in readonly mode (elastic#54073)
  [ML] Support search for partitions on Single Metric Viewer (elastic#53879)
  update apm index pattern (elastic#54095)
  Add data ui for envoyproxy Metricbeat Module (elastic#53476)
  [ML] persist the brush when expanded to full width (elastic#54020)
  Skip failing test (elastic#54100)
  [APM] Show errors on the timeline instead of under the transaction (elastic#53756)
  ...
darnautov added a commit that referenced this pull request Jan 8, 2020
@darnautov
[ML] persist the brush when expanded to full width (#54020) (#54139)
ee5dbdc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

Assignees

@darnautov darnautov

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:enhancement v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Single metric viewer - time slider hidden when expanded to full width
6 participants
@darnautov @elasticmachine @kibanamachine @pheyos @alvarezmelissa87 @peteharverson