[SIEM] Fix doubled drag handles in Timeline #52679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
patrykkopycinski
added
release_note:skip
💔 Build FailedHistory
To update your PR or re-run it, just comment with: |
patrykkopycinski
requested review from
angorayc,
afgomez,
FrankHassanabad,
stephmilovic and
rylnd
and removed request for
afgomez
…multiple-draggables # Conflicts: # x-pack/legacy/plugins/siem/public/components/drag_and_drop/draggable_wrapper.tsx # x-pack/legacy/plugins/siem/public/components/event_details/event_fields_browser.tsx # x-pack/legacy/plugins/siem/public/components/timeline/body/renderers/formatted_field.test.tsx
|
@elasticmachine merge upstream |
| (_, i) => <Cell cellColor={cellColor} cellMargin={cellMargin} key={i} />, | ||
| [cellCount] | ||
| ), | ||
| [cellCount] |
There was a problem hiding this comment.
consider listing cellColor and cellMargin as dependencies
| ...fieldsByName[item.field], | ||
| valuesConcatenated: item.values != null ? item.values.join() : '', | ||
| })), | ||
| [] |
There was a problem hiding this comment.
consider listing data and fieldsByName as dependencies
| </EuiToolTip> | ||
| </TruncatableText> | ||
| ) : ( | ||
| } else if (columnNamesNotDraggable.includes(fieldName)) { |
andrew-goldstein
approved these changes
Jan 7, 2020
There was a problem hiding this comment.
Thanks @patrykkopycinski for this fix and cleanup! 🙏
Verified locally that this fixes the double drag handles in:
✅ timeline / event viewer columns
✅ expanded events
Please consider declaring the additional dependencies to useMemo per the comments below. Everything else is LGTM! 🚀 🙏
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 7, 2020
…le-saved-objects * 'master' of github.com:elastic/kibana: (86 commits) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) [SIEM] Enable eslint react/no-children-prop (elastic#53985) [DOCS][Reporting] Adds info about using a custom reporting index (elastic#54052) Changing background color to align with EUI color (elastic#54060) Fix linting issues (elastic#54068) NP Migration: Move doc views registry and existing doc views into discover plugin (elastic#53465) [ML] DF Analytics job creation: Add 'excludes' input field to form (elastic#53856) EMT-issue-65: add endpoint list api (elastic#53861) [SIEM] Fix doubled drag handles in Timeline (elastic#52679) Functional tests: refactor visualize_page (elastic#53845) [Dashboard] Redesign empty screen in readonly mode (elastic#54073) [ML] Support search for partitions on Single Metric Viewer (elastic#53879) update apm index pattern (elastic#54095) Add data ui for envoyproxy Metricbeat Module (elastic#53476) [ML] persist the brush when expanded to full width (elastic#54020) Skip failing test (elastic#54100) [APM] Show errors on the timeline instead of under the transaction (elastic#53756) ... # Conflicts: # src/legacy/core_plugins/console/public/np_ready/application/contexts/services_context.tsx # src/legacy/core_plugins/console/public/np_ready/application/index.tsx
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Jan 7, 2020
…/kibana into feature/console-saved-objects * 'feature/console-saved-objects' of github.com:jloleysens/kibana: (86 commits) [Uptime] Added date range filter into expanded list query (elastic#52609) [SIEM] Add react/display-name eslint rule (elastic#53107) [SIEM] Enable eslint prefer-template rule (elastic#53983) Elasticsearch snapshots automation (elastic#53706) [SIEM] Enable eslint react/no-children-prop (elastic#53985) [DOCS][Reporting] Adds info about using a custom reporting index (elastic#54052) Changing background color to align with EUI color (elastic#54060) Fix linting issues (elastic#54068) NP Migration: Move doc views registry and existing doc views into discover plugin (elastic#53465) [ML] DF Analytics job creation: Add 'excludes' input field to form (elastic#53856) EMT-issue-65: add endpoint list api (elastic#53861) [SIEM] Fix doubled drag handles in Timeline (elastic#52679) Functional tests: refactor visualize_page (elastic#53845) [Dashboard] Redesign empty screen in readonly mode (elastic#54073) [ML] Support search for partitions on Single Metric Viewer (elastic#53879) update apm index pattern (elastic#54095) Add data ui for envoyproxy Metricbeat Module (elastic#53476) [ML] persist the brush when expanded to full width (elastic#54020) Skip failing test (elastic#54100) [APM] Show errors on the timeline instead of under the transaction (elastic#53756) ...
patrykkopycinski
added a commit
that referenced
this pull request
Jan 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
plain_column_rendererFixes #48813
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers