-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v17.3.1 #53655
Upgrade EUI to v17.3.1 #53655
Conversation
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Security/Spaces changes LGTM. Tested locally.
// @ts-ignore | ||
EuiHighlight, | ||
} from '@elastic/eui'; | ||
import { EuiComboBox, EuiComboBoxOptionProps, EuiHealth, EuiHighlight } from '@elastic/eui'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because this is still better than what it used to be but I am still worried we're potentially masking some bugs and pretending they're data...
@@ -208,7 +208,11 @@ export const dateHistogramOperation: OperationDefinition<DateHistogramIndexPatte | |||
<EuiFlexItem> | |||
<EuiFieldNumber | |||
data-test-subj="lensDateHistogramValue" | |||
value={interval.value} | |||
value={ | |||
typeof interval.value === 'number' || interval.value === '' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super problematic but seems odd that EUI accepts a number or an empty string... (Am I reading that right?)
I'd expect a type signature more like number | undefined
maybe?
Also, does this need a NaN
check?
value={ | ||
typeof interval.value === 'number' || interval.value === '' | ||
? interval.value | ||
: parseInt(interval.value, 10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe not for an EUI update PR but is this really a good spot to do this?
If a non-number has gotten to this point, would it be better to throw an error rather the furthering the rabbit hole of chasing down bad data? Basically, this could lead to subtle bugs that cause people to make mistakes assuming the data is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the options here are to cast value
as EuiFieldNumberProps['value']
or attempt to resolve any errors (like so).
Earlier in the script, parseInterval
has already transformed interval.value
into number | ''
like we want. Elsewhere in this file, though, interval.value
is expected to be a string
.
@@ -186,7 +186,11 @@ export const JsonWatchEditSimulate = ({ | |||
<EuiFlexGroup> | |||
<EuiFlexItem> | |||
<EuiFieldNumber | |||
value={scheduledTimeValue} | |||
value={ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same discussion questions as above for all of these
Agreed, @myasonik. This maintains parity, but does highlight some places where data types should be evaluated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
App Arch code changes LGTM.
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* eui to 17.3.0 * eui to 17.3.1 * TS updates * snapshot updates * update data-test-subj Co-authored-by: Elastic Machine <[email protected]>
* eui to 17.3.0 * eui to 17.3.1 * TS updates * snapshot updates * update data-test-subj Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
…le-saved-objects * 'master' of github.com:elastic/kibana: (250 commits) Allow chromeless applications to render via non-/app routes (elastic#51527) Add server rendering service to enable standalone route rendering (elastic#52161) Possibility to filter when testing scripted fields (elastic#35379) (elastic#44220) Update maps telemetry mappings to account for recent updates (elastic#53803) [Maps] Only show legend when layer is visible (elastic#53781) remove use of experimental fs.promises api (elastic#53346) [APM] Add log statements for flaky test (elastic#53775) [APM] Transaction page throws unhandled exception if transactions doesn't have `http.request` (elastic#53760) Licensing plugin functional tests (elastic#53580) [Lens] Disable saving visualization until there are no changes to the document (elastic#52982) [Monitoring] Added safeguard for some EUI components (elastic#53318) [Vega] Shim new platform - cleanup vega_visualization dependencies (elastic#53605) Display changed field formats without requiring hard page refresh. (elastic#53746) Upgrade EUI to v17.3.1 (elastic#53655) [APM] Fix missing apm indicies (elastic#53541) Disable inspector for timelion (elastic#53747) Clean up search servie (elastic#53701) [Dashboard] Grid: removing double handler (elastic#53707) Remove SavedObjectRegistryProvider from codebase (elastic#53455) Move ui/courier into data shim plugin (elastic#52359) ...
* eui to 17.3.0 * eui to 17.3.1 * TS updates * snapshot updates * update data-test-subj Co-authored-by: Elastic Machine <[email protected]>
Summary
[email protected]
⏩[email protected]
17.3.1
Bug fixes
EuiTextArea
andEuiFieldNumber
(#2703)17.3.0
EuiFieldNumber
to Typescript (#2685)EuiFieldPassword
to Typescript (#2683)EuiHighlight
to Typescript (#2681)data-test-subj
property to theEuiCodeEditor
component (#2689)EuiTextArea
to Typescript (#2695)EuiPage
and related child components to TypeScript (#2669)annotation
glyph (#2691)initialWidth
andisResizable
configurations toEuiDataGrid
's columns (#2696)Bug fixes
toggleOpen
method fromEuiNavDrawer
(#2682)EuiDataGrid
update performance (#2676)EuiDatagrid
header top border when configured to have no toolbar (#2619)17.2.1
[...]
Bug fixes
*.test.tsx?
files from eui.d.ts (#2673)17.2.0
EuiNavDrawer
lock button state viaaria-pressed
(#2643)EuiDataGrid
(#2640)Bug fixes
EuiDataGrid
update performance (#2638)EuiDroppable
not accepting multiple children when using TypeScript (#2634)EuiComboBox
from submitting parentform
element when selecting options viaEnter
key (#2642)EuiNavDrawer
expand button from losing focus after click (#2643)EuiPopover
id
attributes (#2667)