Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiNavDrawer a11y, pt. 1 #2643

Merged
merged 4 commits into from
Dec 13, 2019
Merged

EuiNavDrawer a11y, pt. 1 #2643

merged 4 commits into from
Dec 13, 2019

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Dec 12, 2019 •
edited
Loading

Summary

Chipping away at #2252

  • On clicking the expand/collapse button, focus management is lost and is returned to the body. (It should stay on the button.)

  • The dock/undock button should have aria-pressed=true|false defined to communicate state. This can replace the role=switch and aria-checked=true|false

  • Some clean up to remove an unused method and an outdated comment

Checklist

- [ ] Checked in dark mode
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox

  • Props have proper autodocs

- [ ] Added documentation examples
- [ ] Added or updated jest tests
- [ ] Checked for breaking changes and labeled appropriately

  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@thompsongl thompsongl requested review from snide and myasonik December 12, 2019 20:30
@myasonik myasonik mentioned this pull request Dec 12, 2019
Closed
11 tasks
myasonik
myasonik approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@myasonik myasonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

snide
snide approved these changes Dec 12, 2019
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a CL, otherwise looks good.

@thompsongl thompsongl merged commit fbe66d5 into elastic:master Dec 13, 2019
This was referenced Dec 17, 2019
Merged
Merged
@snide snide mentioned this pull request Jan 11, 2020
Closed
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myasonik myasonik myasonik approved these changes

@snide snide snide approved these changes

Assignees
No one assigned
Labels
accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thompsongl @snide @myasonik