-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SIEM] Fix Edit Filter suggestions displayed behind Filter Popover #53166
[SIEM] Fix Edit Filter suggestions displayed behind Filter Popover #53166
Conversation
Pinging @elastic/siem (Team:SIEM) |
💚 Build SucceededTo update your PR or re-run it, just comment with: |
/* | ||
overrides the default styling of euiComboBoxOptionsList because it's implemented | ||
as a popover, so it's not selectable as a child of the styled component | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for keeping these comments around -- will be beneficial to our future selves! 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked out locally, verified fix on the SIEM Global Filter, Timeline Filter, and Signals Create Rule Filter, and performed code review.
Loooooks good to me! Thanks for the quick-fix @patrykkopycinski 👍 🚀
Note: The field selection list flashing at 0,0 when first clicking the filter is a pre-existing issue. See #49962 for details.
@spong Thank you for the review 💪 I've checked the issue you mentioned, it seems the focus is triggered before the animation is finished. Here is a PR that, in my opinion, should fix that elastic/eui#2614 |
Summary
Fixes #52329
styled-components
bump changed the way how global styles are propagated, so to keep the previous behavior I've moved some styles overrides to theAppGlobalStyle
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers