Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move apply filters popover ⇒ NP #51566

Merged
merged 3 commits into from
Nov 26, 2019
Merged

Move apply filters popover ⇒ NP #51566

merged 3 commits into from
Nov 26, 2019

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Nov 25, 2019

Summary

Part of #51022
Move apply filters popover ⇒ NP

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@lizozom lizozom self-assigned this Nov 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom lizozom mentioned this pull request Nov 25, 2019
Closed
3 tasks
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom requested a review from lukeelmers November 25, 2019 15:32
@lizozom lizozom force-pushed the newplatform/data-plugin/apply-filters branch from 3a7dbcb to c852783 Compare November 25, 2019 15:59
@lizozom lizozom marked this pull request as ready for review November 25, 2019 16:00
@lizozom lizozom requested review from a team as code owners November 25, 2019 16:00
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

joshdover
joshdover approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration guide changes LGTM

Dosant
Dosant approved these changes Nov 26, 2019
View reviewed changes
Copy link
Contributor

@Dosant Dosant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM

src/plugins/data/public/ui/apply_filters/apply_filters_popover.tsx Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@lizozom lizozom merged commit 9e16839 into elastic:master Nov 26, 2019
lizozom pushed a commit to lizozom/kibana that referenced this pull request Nov 26, 2019
Move apply filters popover ⇒ NP (elastic#51566)
8f36b5c 
* Move ApplyFiltersPopoverContent and applyFiltersPopover to NP

* code review
@lizozom lizozom mentioned this pull request Nov 26, 2019
Merged
lizozom pushed a commit that referenced this pull request Nov 26, 2019
Move apply filters popover ⇒ NP (#51566) (#51704)
f44a220 
* Move ApplyFiltersPopoverContent and applyFiltersPopover to NP

* code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dosant Dosant Dosant approved these changes

@joshdover joshdover joshdover approved these changes

@lukeelmers lukeelmers Awaiting requested review from lukeelmers

Assignees

@lizozom lizozom

Labels
Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lizozom @elasticmachine @joshdover @Dosant