-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] DF Analytics Regression results: rerun evaluate endpoint for search bar queries #50991
Changes from 6 commits
d1f76a0
167458e
9a35bbc
393cc6e
494ac87
5fc0e87
629d3fd
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
@import 'pages/analytics_exploration/components/exploration/index'; | ||
@import 'pages/analytics_exploration/components/regression_exploration/index'; | ||
@import 'pages/analytics_management/components/analytics_list/index'; | ||
@import 'pages/analytics_management/components/create_analytics_form/index'; | ||
@import 'pages/analytics_management/components/create_analytics_flyout/index'; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
@import 'regression_exploration'; |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.mlDataFrameAnalyticsRegression__evaluateStat span.euiToolTipAnchor { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @alvarezmelissa87 Don't forget that you can pass custom classnames to EuiToolTip anchors with the prop There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the reminder 😄 Updated to use |
||
padding-top: $euiSizeL; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the query matches just one document, I've seen that
r_squared
is returned by the evaluate endpoint as-Infinity
. Can you check if this is correct, and if so,getValuesFromResponse
needs to handle this case as currently it throws an error when callingtoPrecision
and the stats show up as--
(the mean_squared_error is a value and could be displayed).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is caused because if there is only one doc variance is 0 - this was then being divided by 0 in the calculation to get rSquared. Instead of dividing by 0, 0 should just be returned.
A fix for this is up already elastic/elasticsearch#49439
We shouldn't need to do any additional checking in the UI.