-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] DF Analytics Regression results: rerun evaluate endpoint for search bar queries #50991
Merged
alvarezmelissa87
merged 7 commits into
elastic:master
from
alvarezmelissa87:ml-regression-updates
Nov 21, 2019
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d1f76a0
update evaluate panel values
alvarezmelissa87 167458e
re-evaluate endpoint with subquery
alvarezmelissa87 9a35bbc
wip: add document count for training/gen evaluate
alvarezmelissa87 393cc6e
add document count for training/gen evaluate continued
alvarezmelissa87 494ac87
use toolTipIcon, remove unnecessary comment
alvarezmelissa87 5fc0e87
typescript improvements
alvarezmelissa87 629d3fd
use anchorClassName instead of targetin eui class directly
alvarezmelissa87 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
x-pack/legacy/plugins/ml/public/data_frame_analytics/_index.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
@import 'pages/analytics_exploration/components/exploration/index'; | ||
@import 'pages/analytics_exploration/components/regression_exploration/index'; | ||
@import 'pages/analytics_management/components/analytics_list/index'; | ||
@import 'pages/analytics_management/components/create_analytics_form/index'; | ||
@import 'pages/analytics_management/components/create_analytics_flyout/index'; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 1 addition & 0 deletions
1
...frame_analytics/pages/analytics_exploration/components/regression_exploration/_index.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
@import 'regression_exploration'; |
3 changes: 3 additions & 0 deletions
3
...ages/analytics_exploration/components/regression_exploration/_regression_exploration.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
.mlDataFrameAnalyticsRegression__evaluateStat { | ||
padding-top: $euiSizeL; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the query matches just one document, I've seen that
r_squared
is returned by the evaluate endpoint as-Infinity
. Can you check if this is correct, and if so,getValuesFromResponse
needs to handle this case as currently it throws an error when callingtoPrecision
and the stats show up as--
(the mean_squared_error is a value and could be displayed).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is caused because if there is only one doc variance is 0 - this was then being divided by 0 in the calculation to get rSquared. Instead of dividing by 0, 0 should just be returned.
A fix for this is up already elastic/elasticsearch#49439
We shouldn't need to do any additional checking in the UI.