-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move @kbn/es-query into data plugin - remove unused code #50903
Conversation
Pinging @elastic/kibana-app-arch (Team:AppArch) |
💔 Build Failed |
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old code removal LGTM
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code was only used in the first version of kuery where filters would get converted to kuery and added to the query string. Definitely no longer used and safe to delete.
Summary
Part of #42885
During moving code from @kbn/es-query/kuery folder into new platform I found some legacy code (in filter_migration folder) which we don't use any more.
In this PR, I just want to double check that we do not need it, and this code can be safely deleted
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers