Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move @kbn/es-query into data plugin #42885

Closed
9 of 10 tasks
lukeelmers opened this issue Aug 7, 2019 · 4 comments
Closed
9 of 10 tasks

Move @kbn/es-query into data plugin #42885

lukeelmers opened this issue Aug 7, 2019 · 4 comments
Assignees
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:NP Migration

Comments

@lukeelmers
Copy link
Member

lukeelmers commented Aug 7, 2019

In #42012 it was decided that we would move the @kbn/es-query package into the data plugin. This will help solve some problems of shared type interfaces (specifically Field and IndexPattern), but it also makes sense to have data be the home for this package.

Prepare @kbn/es-query for moving into data plugin:

The utility functions and types will be exported from the data plugin grouped inside objects, to give them context:

export const filters = {
   // TYPES
   ExistsFilter,
   RangeFilter,
   ...
   // Utility functions
   buildExistsFitler,
   buildRangeFilter,
   ...
}
@lukeelmers lukeelmers added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppArch Feature:NP Migration labels Aug 7, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@lizozom
Copy link
Contributor

lizozom commented Sep 12, 2019

Please hold off on this task until we finish the data plugin RFC

@TinaHeiligers
Copy link
Contributor

Please also reach out to me before starting this work. I need some of the methods in the package to be stateful and have access to saved objects so that we can use saved queries by reference rather than cloning them. This will allow us to keep saved queries used everywhere (including filters and filter aggregations) in sync.

@Bargs
Copy link
Contributor

Bargs commented Oct 29, 2019

@alexwizp I heard you're starting to work on this. I wanted to let you know I have a couple of PRs that make significant changes and additions to the package. The larger PR is already fully implemented and tested and is only awaiting final review before merging, so you may want to hold off on the migration effort until that is in.

#47070
#49537

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:NP Migration
Projects
None yet
Development

No branches or pull requests

6 participants