-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move @kbn/es-query into data plugin #42885
Comments
Pinging @elastic/kibana-app-arch |
Please hold off on this task until we finish the data plugin RFC |
Please also reach out to me before starting this work. I need some of the methods in the package to be stateful and have access to saved objects so that we can use saved queries by reference rather than cloning them. This will allow us to keep saved queries used everywhere (including filters and filter aggregations) in sync. |
@alexwizp I heard you're starting to work on this. I wanted to let you know I have a couple of PRs that make significant changes and additions to the package. The larger PR is already fully implemented and tested and is only awaiting final review before merging, so you may want to hold off on the migration effort until that is in. |
In #42012 it was decided that we would move the
@kbn/es-query
package into thedata
plugin. This will help solve some problems of shared type interfaces (specificallyField
andIndexPattern
), but it also makes sense to havedata
be the home for this package.Prepare @kbn/es-query for moving into data plugin:
@kbn/es-query -> 'src/plugins/data/{server|public}
[Move @kbn/es-query into data plugin - kuery folder #51014] @alexwizp;The utility functions and types will be exported from the
data
plugin grouped inside objects, to give them context:The text was updated successfully, but these errors were encountered: