[Maps] move apply global filter settting from layer to source #50523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
nreese
added
release_note:enhancement
[Deprecated-Use Team:Presentation]Team:Geo
|
Pinging @elastic/kibana-gis (Team:Geo) |
|
Pinging @elastic/kibana-docs (Team:Docs) |
|
@spong I added you as a review since this PR touches the layer definitions in SIEM. Would you mind reviewing the SIEM changes? |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
thomasneirynck
approved these changes
Nov 18, 2019
There was a problem hiding this comment.
Great PR.
This was flagged during this PR, although not directly related:
wrt
After discussion, we decided to change this to getSourceIndexPatterns. The filter should only apply to the source-data, not any of the term-joins. That is actually the current behavior, and documented like this (https://www.elastic.co/guide/en/kibana/7.x/maps-layer-based-filtering.html). The UX shouldn't include auto-complete for any of the join-indices, as that wouldn't function anyway.
...legacy/plugins/maps/public/connected_components/layer_panel/layer_settings/layer_settings.js
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/sources/client_file_source/geojson_file_source.js
Show resolved
Hide resolved
💔 Build Failed |
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Nov 18, 2019
…c#50523) * [Maps] move apply global filter settting from layer to source * add checkbox to join UI * update edit UI for grid and pew-pew source * add migrations * update docs * remove setting of applyGlobalQuery from geojson upload * upgrade SIEM layer descriptors * fix jest tests and api integration tests * fix functional tests * fix functional test * i18n * review feedback * doc re-wording * i18n fixes
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 18, 2019
…-fallback * 'master' of github.com:elastic/kibana: (116 commits) [Maps] move apply global filter settting from layer to source (elastic#50523) [SIEM] Fix: Empty `Source` / `Destination` shown when only ports are populated (elastic#50843) [Maps] Delay vector tile layer syncing until spritesheet is loaded (elastic#48955) [Maps] prevent users from overflowing URL when filtering by shape (elastic#50747) [DOCS] Mark Beats central management as discontinued (elastic#49423) [page_objects/common_page] convert to ts (elastic#50771) [NP Kibana Migrations ] kibana plugin home (elastic#50444) [DOCS] Shareables naming convention (elastic#50497) [ML] DF Analytics - auto-populate model_memory_limit (elastic#50714) Increase alerting test stability and reduce flakiness (elastic#50246) [ML] Remaning new_job_new folder (elastic#50917) [Telemetry] Show opt-in changes for OSS users (elastic#50831) [ML] Fix lat_long anomalies table links menu and value formatting (elastic#50916) [Dev] Fix serialising a really big string (elastic#50915) Better explanation about the Prettier recommendation (extension vs. NPM module) (elastic#50629) [Monitoring] Use a basic monitoring user for tests (elastic#47865) [Monitoring] Gracefully handle issue with filebeat indices (elastic#48929) [Monitoring] Improve permissions required around setup mode (elastic#50421) Additional validation for elasticsearch username (elastic#48247) Revert changes to use_kibana_ui_setting (elastic#50877) ... # Conflicts: # src/legacy/core_plugins/console/server/request.test.ts
nreese
added a commit
that referenced
this pull request
Nov 18, 2019
#50972) * [Maps] move apply global filter settting from layer to source * add checkbox to join UI * update edit UI for grid and pew-pew source * add migrations * update docs * remove setting of applyGlobalQuery from geojson upload * upgrade SIEM layer descriptors * fix jest tests and api integration tests * fix functional tests * fix functional test * i18n * review feedback * doc re-wording * i18n fixes
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #43849
This PR moves
applyGlobalQueryfrom the layer descriptor to the source descriptor. That way, you can enable/disable global query context for the source or each join independently.This PR also effects GeoJson upload.
applyGlobalQueryis no longer defaulted false for GeoJson upload layers.To test this PR you need to have a document index in ES that can be joined with another document index in ES. The get-it-done data set along with San Diego council districts provides a good example where you want to filter the join source by get-it-done data set but want to avoid filtering the council district polygons by global search criteria. Follow the instructions at https://github.com/nreese/presentations/tree/master/get_it_done to load get_it_done data set and council district geojson.