[Monitoring] Use a basic monitoring user for tests #47865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisronline
added
Feature:Stack Monitoring
Team:Monitoring
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
💔 Build Failed
|
|
I am going to kick off a new CI build once elastic/elasticsearch#47871 has made it's way into a snapshot - it should resolve the failures |
|
Waiting on this #47217 before we can resume the work in this PR |
💔 Build Failed
|
|
@elasticmachine merge upstream |
💔 Build Failed
|
chrisronline
added
v7.4.3
v7.5.1
v7.6.0
v8.0.0
release_note:skip
💔 Build Failed
|
chrisronline
force-pushed
the
monitoring/monitoring_user_in_tests
branch
from
079621e to
2e6abe3
Compare
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
|
retest |
💚 Build Succeeded |
igoristic
reviewed
Nov 17, 2019
| async navigateTo() { | ||
| async navigateTo(useSuperUser = false) { | ||
| // always create this because our tear down tries to delete it | ||
| await security.user.create('basic_monitoring_user', { |
There was a problem hiding this comment.
Shouldn't this maybe be inside this: https://github.com/elastic/kibana/pull/47865/files#diff-b5773aa68cf0bba75970470c4b391bdeR21 if condition?
There was a problem hiding this comment.
I added the comment:
// always create this because our tear down tries to delete it
Because we are always trying to remove it here: https://github.com/elastic/kibana/pull/47865/files#diff-328ca8d955b871223f4463b5a7ce9721R39
I guess I could try/catch that call and do nothing if it fails? I'm not sure the best way here, but at least this way gets the tests to pass (which was a challenge honestly)
There was a problem hiding this comment.
Ah, I see now, this makes sense
igoristic
approved these changes
Nov 18, 2019
|
@elasticmachine merge upstream |
💚 Build Succeeded |
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Nov 18, 2019
* Use a basic monitoring user for tests * Rework this a little to fix the issue that the tests aren't working properly * I think this is what we need to fix the tests * Switch this order, since these tests cause a weird login loop in the current order
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Nov 18, 2019
* Use a basic monitoring user for tests * Rework this a little to fix the issue that the tests aren't working properly * I think this is what we need to fix the tests * Switch this order, since these tests cause a weird login loop in the current order
chrisronline
added a commit
to chrisronline/kibana
that referenced
this pull request
Nov 18, 2019
* Use a basic monitoring user for tests * Rework this a little to fix the issue that the tests aren't working properly * I think this is what we need to fix the tests * Switch this order, since these tests cause a weird login loop in the current order
chrisronline
added a commit
that referenced
this pull request
Nov 18, 2019
* Use a basic monitoring user for tests * Rework this a little to fix the issue that the tests aren't working properly * I think this is what we need to fix the tests * Switch this order, since these tests cause a weird login loop in the current order
chrisronline
added a commit
that referenced
this pull request
Nov 18, 2019
* Use a basic monitoring user for tests * Rework this a little to fix the issue that the tests aren't working properly * I think this is what we need to fix the tests * Switch this order, since these tests cause a weird login loop in the current order
chrisronline
added a commit
that referenced
this pull request
Nov 18, 2019
* Use a basic monitoring user for tests * Rework this a little to fix the issue that the tests aren't working properly * I think this is what we need to fix the tests * Switch this order, since these tests cause a weird login loop in the current order
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 18, 2019
…-fallback * 'master' of github.com:elastic/kibana: (116 commits) [Maps] move apply global filter settting from layer to source (elastic#50523) [SIEM] Fix: Empty `Source` / `Destination` shown when only ports are populated (elastic#50843) [Maps] Delay vector tile layer syncing until spritesheet is loaded (elastic#48955) [Maps] prevent users from overflowing URL when filtering by shape (elastic#50747) [DOCS] Mark Beats central management as discontinued (elastic#49423) [page_objects/common_page] convert to ts (elastic#50771) [NP Kibana Migrations ] kibana plugin home (elastic#50444) [DOCS] Shareables naming convention (elastic#50497) [ML] DF Analytics - auto-populate model_memory_limit (elastic#50714) Increase alerting test stability and reduce flakiness (elastic#50246) [ML] Remaning new_job_new folder (elastic#50917) [Telemetry] Show opt-in changes for OSS users (elastic#50831) [ML] Fix lat_long anomalies table links menu and value formatting (elastic#50916) [Dev] Fix serialising a really big string (elastic#50915) Better explanation about the Prettier recommendation (extension vs. NPM module) (elastic#50629) [Monitoring] Use a basic monitoring user for tests (elastic#47865) [Monitoring] Gracefully handle issue with filebeat indices (elastic#48929) [Monitoring] Improve permissions required around setup mode (elastic#50421) Additional validation for elasticsearch username (elastic#48247) Revert changes to use_kibana_ui_setting (elastic#50877) ... # Conflicts: # src/legacy/core_plugins/console/server/request.test.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #29661