Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rollup] Fix for clone job workflow #50501

Merged
merged 3 commits into from
Nov 14, 2019

Conversation

jloleysens
Copy link
Contributor

@jloleysens jloleysens commented Nov 13, 2019

Summary

Addresses this issue: #50486

How to review

See issue for details on how to reproduce.

  • It's important that the standard rollup job creation flow remains unaffected
  • The primary change this contribution proposes is that we update the index revalidation function's API to include the option to not reset defaults. This should only be called once in this fashion. When we enter job creation with a clone rollup job.

Todo

Add a test

Release Notes

We fixed a bug that prevented users from cloning rollup jobs if they changed the index pattern in the first step of the wizard.

@jloleysens jloleysens added Feature:Rollups release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.4.3 v7.5.0 v7.6.0 v8.0.0 labels Nov 13, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@jloleysens jloleysens changed the title [Rollup] First iteration of fix for clone job workflow [Rollup] Fix for clone job workflow Nov 13, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

Copy link
Contributor

@alisonelizabeth alisonelizabeth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally. Changes LGTM. Thanks for fixing this!

@alisonelizabeth
Copy link
Contributor

@jloleysens can you add a Release notes section to the PR description?

@jloleysens jloleysens merged commit d43c5c6 into elastic:master Nov 14, 2019
@jloleysens jloleysens deleted the fix/rollup-job-clone branch November 14, 2019 09:12
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 14, 2019
* First iteration of fix for clone job workflow

* Second iteration of fix, previous had race condition :gasp:

* Slight revision to logic and added test for wizard with rollup job after index pattern changed
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 14, 2019
* First iteration of fix for clone job workflow

* Second iteration of fix, previous had race condition :gasp:

* Slight revision to logic and added test for wizard with rollup job after index pattern changed
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 14, 2019
* First iteration of fix for clone job workflow

* Second iteration of fix, previous had race condition :gasp:

* Slight revision to logic and added test for wizard with rollup job after index pattern changed
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 14, 2019
* 'master' of github.com:elastic/kibana: (27 commits)
  [Rollup] Fix for clone job workflow (elastic#50501)
  Empty message "No data available" for Labels and User metadata sections missing (elastic#49846)
  [APM] Duration by Country map doesn't take `transactionName` into account (elastic#50315)
  Remove react references from core `Notifications` apis (elastic#49573)
  Updated APM Indices endpoints to use the SavedObjectsClient from the legacy request context, and set the apm-indices schema object to be namspace-agnostic
  [Metrics UI] Calculate interval based on the dataset's period (elastic#50194)
  chore(NA): add new platform discovered plugins as entry points to check for dependencies on clean dll tasks (elastic#50610)
  [Telemetry] change of optin status telemetry (elastic#50158)
  [SIEM][Detection Engine] REST API Additions (elastic#50514)
  [DOCS] Removes dashboard-only mode doc (elastic#50441)
  [Filters] Fix operator overflowing out popover (elastic#50030)
  Change telemetry optIn to default to true (elastic#50490)
  [Maps] make grid rectangles the default symbolization for geo grid source (elastic#50169)
  Allow registered applications to hide Kibana chrome (elastic#49795)
  Upgrade EUI to v14.9.0 (elastic#49678)
  [Metrics UI] Convert layouts to use React components (elastic#49134)
  [Search service] Add support for ES request preference (elastic#49424)
  [Newsfeed/Lint] fix chained fn lint (elastic#50515)
  [Monitoring] Fix logstash pipelines page in multi-cluster environment (elastic#50166)
  [SIEM] Events viewer fixes (elastic#50175)
  ...
jloleysens added a commit that referenced this pull request Nov 14, 2019
* First iteration of fix for clone job workflow

* Second iteration of fix, previous had race condition :gasp:

* Slight revision to logic and added test for wizard with rollup job after index pattern changed
jloleysens added a commit that referenced this pull request Nov 14, 2019
* First iteration of fix for clone job workflow

* Second iteration of fix, previous had race condition :gasp:

* Slight revision to logic and added test for wizard with rollup job after index pattern changed
jloleysens added a commit that referenced this pull request Nov 14, 2019
* First iteration of fix for clone job workflow

* Second iteration of fix, previous had race condition :gasp:

* Slight revision to logic and added test for wizard with rollup job after index pattern changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Rollups release_note:fix Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.4.3 v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants