Fix operator overflowing out popover #50030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
1 similar comment
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
@cchaos could I bother you for a review on this one, please. |
cchaos
suggested changes
Nov 13, 2019
src/legacy/core_plugins/data/public/filter/filter_bar/_index.scss
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/data/public/filter/filter_bar/filter_editor/_filter_editor.scss
Outdated
Show resolved
Hide resolved
src/legacy/core_plugins/data/public/filter/filter_bar/filter_editor/index.tsx
Outdated
Show resolved
Hide resolved
class name to conform to the BEM naming convention
cchaos
approved these changes
Nov 13, 2019
|
Jenkins, test this |
|
@ffknob We've recently updated our linting in Kibana. Can you fix the ESLint error reported here: https://github.com/elastic/kibana/pull/50030/checks?check_run_id=301639877 |
💔 Build Failed |
I ran a |
|
Jenkins, test this |
💚 Build Succeeded |
This was referenced Nov 13, 2019
cchaos
pushed a commit
to cchaos/kibana
that referenced
this pull request
Nov 13, 2019
* Fixes combo overflow when the selected field is large * Prettier quotes * Changes the style class attribute to use Eui calculation and also the class name to conform to the BEM naming convention * Lints src/plugins/newsfeed/public/lib/api.test.ts
cchaos
added a commit
that referenced
this pull request
Nov 14, 2019
* Fixes combo overflow when the selected field is large * Prettier quotes * Changes the style class attribute to use Eui calculation and also the class name to conform to the BEM naming convention * Lints src/plugins/newsfeed/public/lib/api.test.ts
cchaos
added a commit
that referenced
this pull request
Nov 14, 2019
* Fixes combo overflow when the selected field is large * Prettier quotes * Changes the style class attribute to use Eui calculation and also the class name to conform to the BEM naming convention * Lints src/plugins/newsfeed/public/lib/api.test.ts
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 14, 2019
* 'master' of github.com:elastic/kibana: (27 commits) [Rollup] Fix for clone job workflow (elastic#50501) Empty message "No data available" for Labels and User metadata sections missing (elastic#49846) [APM] Duration by Country map doesn't take `transactionName` into account (elastic#50315) Remove react references from core `Notifications` apis (elastic#49573) Updated APM Indices endpoints to use the SavedObjectsClient from the legacy request context, and set the apm-indices schema object to be namspace-agnostic [Metrics UI] Calculate interval based on the dataset's period (elastic#50194) chore(NA): add new platform discovered plugins as entry points to check for dependencies on clean dll tasks (elastic#50610) [Telemetry] change of optin status telemetry (elastic#50158) [SIEM][Detection Engine] REST API Additions (elastic#50514) [DOCS] Removes dashboard-only mode doc (elastic#50441) [Filters] Fix operator overflowing out popover (elastic#50030) Change telemetry optIn to default to true (elastic#50490) [Maps] make grid rectangles the default symbolization for geo grid source (elastic#50169) Allow registered applications to hide Kibana chrome (elastic#49795) Upgrade EUI to v14.9.0 (elastic#49678) [Metrics UI] Convert layouts to use React components (elastic#49134) [Search service] Add support for ES request preference (elastic#49424) [Newsfeed/Lint] fix chained fn lint (elastic#50515) [Monitoring] Fix logstash pipelines page in multi-cluster environment (elastic#50166) [SIEM] Events viewer fixes (elastic#50175) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to #49961
Fixes combo overflow when selecting value (field name) too large to fit in the popover.
Before:
After:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers