Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Detection engine placeholders #50220

Merged
merged 80 commits into from
Nov 13, 2019
Merged
Changes from 1 commit
Commits
Show all changes
80 commits
Select commit Hold shift + click to select a range
f4b0f91
attempt at getting nav working
MichaelMarcialis Oct 7, 2019
66a5154
fix detection-engine href redirect issue
stephmilovic Oct 7, 2019
178827e
Merge pull request #1 from stephmilovic/michael-detection-engine
Oct 7, 2019
7d34c25
rough out basic page routing
MichaelMarcialis Oct 8, 2019
1df2e98
kql placeholder
MichaelMarcialis Oct 8, 2019
ca77faa
update page and panel headers
MichaelMarcialis Oct 10, 2019
f85d4b7
Merge branch 'master' of https://github.com/elastic/kibana into featu…
MichaelMarcialis Oct 10, 2019
ab39bfc
rough out card table poc styles
MichaelMarcialis Oct 10, 2019
f82a179
change HeaderPanel to HeaderSection
MichaelMarcialis Oct 10, 2019
30d5053
cleanup and unit test updates
MichaelMarcialis Oct 10, 2019
c847e77
rough out utilityBar poc
MichaelMarcialis Oct 11, 2019
33b3d33
clean up UtilityBar naming and styles
MichaelMarcialis Oct 14, 2019
89c2497
Merge branch 'master' of https://github.com/elastic/kibana into featu…
MichaelMarcialis Oct 14, 2019
a4a8bef
support popovers in utility bar
MichaelMarcialis Oct 14, 2019
c6f96c6
refactor icon side
MichaelMarcialis Oct 15, 2019
8b1b580
UtilityBar unit tests
MichaelMarcialis Oct 15, 2019
f2d7f64
Merge branch 'master' of https://github.com/elastic/kibana into featu…
MichaelMarcialis Oct 15, 2019
d2837d0
remove page tests for now
MichaelMarcialis Oct 15, 2019
e2d0a34
adjust routes
MichaelMarcialis Oct 15, 2019
955bbc1
add comment
MichaelMarcialis Oct 15, 2019
3ff9af4
cleanup chart
MichaelMarcialis Oct 15, 2019
630e77e
open/closed signals content toggle
MichaelMarcialis Oct 16, 2019
9c934f5
Merge branch 'master' of https://github.com/elastic/kibana into featu…
MichaelMarcialis Oct 16, 2019
91b39b4
remove EuiFilterButton icons
MichaelMarcialis Oct 16, 2019
9f32e1d
fix misaligned popover button
MichaelMarcialis Oct 16, 2019
4027a65
add split prop for HeaderSection
MichaelMarcialis Oct 16, 2019
92f063f
fleshing out activity monitor table
MichaelMarcialis Oct 16, 2019
a185185
Merge branch 'master' of https://github.com/elastic/kibana into featu…
MichaelMarcialis Oct 21, 2019
f8c4acb
update global header to include logo
MichaelMarcialis Oct 21, 2019
0e87c82
Merge branch 'master' of https://github.com/elastic/kibana into featu…
MichaelMarcialis Oct 21, 2019
9cdcceb
fix tests
MichaelMarcialis Oct 21, 2019
247710d
correct table types; thanks Garrett!
MichaelMarcialis Oct 22, 2019
abbb9eb
Merge branch 'master' of https://github.com/elastic/kibana into featu…
MichaelMarcialis Oct 22, 2019
0d14389
LinkIcon comp poc
MichaelMarcialis Oct 23, 2019
57cd4fd
fix bugs, errors, tests
MichaelMarcialis Oct 23, 2019
1531fcf
rm import
MichaelMarcialis Oct 23, 2019
00829b6
Merge branch 'master' of https://github.com/elastic/kibana into featu…
MichaelMarcialis Oct 23, 2019
bf1f127
table cleanup
MichaelMarcialis Oct 24, 2019
306a3cd
Merge branch 'master' of https://github.com/elastic/kibana into featu…
MichaelMarcialis Oct 28, 2019
02f978d
correct merge errors
MichaelMarcialis Oct 28, 2019
694e0fa
switch All Rules to EuiBasicTable
MichaelMarcialis Oct 28, 2019
caf1926
expand table types and values
MichaelMarcialis Oct 28, 2019
e79634c
fleshing out all rules table
MichaelMarcialis Oct 29, 2019
21522e9
Merge branch 'master' of https://github.com/elastic/kibana into featu…
MichaelMarcialis Oct 29, 2019
1794a2f
rough out rule details
MichaelMarcialis Oct 29, 2019
0f645e6
move chart to separate comp
MichaelMarcialis Oct 29, 2019
d047711
update supplement layout
MichaelMarcialis Oct 29, 2019
a24e05c
example rule fail
MichaelMarcialis Oct 29, 2019
518ef61
switch to new discover-style search
MichaelMarcialis Oct 29, 2019
ed17347
add ProgressInline comp
MichaelMarcialis Oct 30, 2019
8b468f5
update unit tests and snapshots
MichaelMarcialis Oct 30, 2019
59966da
Merge branch 'master' of https://github.com/elastic/kibana into featu…
MichaelMarcialis Oct 30, 2019
3ffc87a
cleanup
MichaelMarcialis Oct 30, 2019
bd86c0e
correct merge weirdness
MichaelMarcialis Oct 30, 2019
1f1a153
move text styles to all subtitle items
MichaelMarcialis Oct 30, 2019
a7ed912
correct invalid nav markup; update tests; cleanup
MichaelMarcialis Oct 30, 2019
8e8b02d
Merge branch 'master' of https://github.com/elastic/kibana into featu…
MichaelMarcialis Oct 31, 2019
8b91841
fix console errors
MichaelMarcialis Oct 31, 2019
3557f1f
add empty page
MichaelMarcialis Oct 31, 2019
b721314
change to EuiButtonEmpty in HeaderGlobal
MichaelMarcialis Oct 31, 2019
93be3cc
overflow popover
MichaelMarcialis Oct 31, 2019
9b3d06c
rough out edit layout
MichaelMarcialis Oct 31, 2019
d6a4212
new WrapperPage comp POC
MichaelMarcialis Nov 1, 2019
9a61c88
cleanup
MichaelMarcialis Nov 1, 2019
8348b74
var for timeline gutter
MichaelMarcialis Nov 1, 2019
914786a
tests and snapshots update
MichaelMarcialis Nov 1, 2019
41cd0eb
Merge branch 'master' of https://github.com/elastic/kibana into featu…
MichaelMarcialis Nov 1, 2019
fe6f6f6
Merge branch 'master' of github.com:elastic/kibana into detection-eng…
XavierM Nov 11, 2019
293ad6b
Merge branch 'master' of github.com:elastic/kibana into detection-eng…
XavierM Nov 12, 2019
66d2113
fix type + review + re-arrange code
XavierM Nov 12, 2019
33da413
adding feature flag + fix route issue
XavierM Nov 12, 2019
4efa800
Merge branch 'master' of github.com:elastic/kibana into detection-eng…
XavierM Nov 12, 2019
514d6dc
Merge branch 'master' into detection-engine-placeholders
elasticmachine Nov 12, 2019
a5c50d8
fix type with unit test
XavierM Nov 12, 2019
b95e1c7
Merge branch 'master' of github.com:elastic/kibana into detection-eng…
XavierM Nov 12, 2019
2263833
Merge branch 'detection-engine-placeholders' of github.com:XavierM/ki…
XavierM Nov 12, 2019
378b77e
Merge branch 'master' into detection-engine-placeholders
elasticmachine Nov 12, 2019
b20ef37
Removing unused translation
spong Nov 12, 2019
71ae091
Merge branch 'master' into detection-engine-placeholders
elasticmachine Nov 12, 2019
12774ab
Merge branch 'master' into detection-engine-placeholders
elasticmachine Nov 13, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
support popovers in utility bar
MichaelMarcialis committed Oct 14, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit a4a8bef5b7873e71077dacf5d76cf456fdd0e022
Original file line number Diff line number Diff line change
@@ -23,6 +23,8 @@ const Link = styled(EuiLink).attrs({

.euiIcon {
margin-right: ${theme.eui.euiSizeXS};
position: relative;
top: -1px;
}
`}
`;
Original file line number Diff line number Diff line change
@@ -107,17 +107,31 @@ export const BarText = styled.p.attrs({
`;
BarText.displayName = 'BarText';

export interface BarActionLinkProps {
export interface BarActionProps {
children: React.ReactNode;
href?: string;
onClick?: Function;
}

export const BarActionLink = styled(EuiLink).attrs({
export const BarAction = styled(EuiLink).attrs({
className: 'siemUtilityBar__action',
})<BarActionLinkProps>`
})<BarActionProps>`
${({ theme }) => css`
font-size: ${theme.eui.euiFontSizeXS};
line-height: ${theme.eui.euiLineHeight};

.euiIcon {
position: relative;
top: -1px;

&:first-child {
margin-right: ${theme.eui.euiSizeXS};
}

&:last-child {
margin-left: ${theme.eui.euiSizeXS};
}
}
`}
`;
BarActionLink.displayName = 'BarActionLink';
BarAction.displayName = 'BarAction';
Original file line number Diff line number Diff line change
@@ -4,17 +4,55 @@
* you may not use this file except in compliance with the Elastic License.
*/

import React from 'react';
import { EuiIcon, EuiPopover, IconType } from '@elastic/eui';
import React, { useState } from 'react';

import { BarActionLink, BarActionLinkProps } from './styles';
import { BarAction, BarActionProps } from './styles';

export interface UtilityBarActionProps extends BarActionLinkProps {
children: React.ReactNode;
interface PopoverProps {
children: BarActionProps['children'];
popoverContent?: React.ReactNode;
}

export const UtilityBarAction = React.memo<UtilityBarActionProps>(({ children, href, onClick }) => (
<BarActionLink href={href} onClick={onClick}>
{children}
</BarActionLink>
));
const Popover = React.memo<UtilityBarActionProps>(({ children, popoverContent }) => {
const [popoverState, setPopoverState] = useState(false);

return (
<EuiPopover
button={
<BarAction onClick={() => setPopoverState(!popoverState)}>
{children}
<EuiIcon size="s" type="arrowDown" />
</BarAction>
}
isOpen={popoverState}
closePopover={() => setPopoverState(false)}
>
{popoverContent}
</EuiPopover>
);
});
Popover.displayName = 'Popover';

export interface UtilityBarActionProps extends BarActionProps {
iconSide?: 'left' | 'right';
iconType?: IconType;
popoverContent?: PopoverProps['popoverContent'];
}

export const UtilityBarAction = React.memo<UtilityBarActionProps>(
({ children, href, iconSide = 'left', iconType, onClick, popoverContent }) => {
if (popoverContent) {
return <Popover popoverContent={popoverContent}>{children}</Popover>;
} else {
return (
<BarAction href={href} onClick={onClick}>
{iconType && iconSide === 'left' && <EuiIcon size="s" type={iconType} />}
{children}
{iconType && iconSide === 'right' && <EuiIcon size="s" type={iconType} />}
</BarAction>
);
}
}
);
UtilityBarAction.displayName = 'UtilityBarAction';
Original file line number Diff line number Diff line change
@@ -144,7 +144,6 @@ export const DetectionEngineComponent = React.memo(() => {
options={toggleButtons}
/>
</HeaderSection>

<UtilityBar>
<UtilityBarSection>
<UtilityBarGroup>
@@ -154,40 +153,34 @@ export const DetectionEngineComponent = React.memo(() => {
<UtilityBarGroup>
<UtilityBarText>{'Selected: 20 signals'}</UtilityBarText>

<UtilityBarAction>
{'Batch actions'} <EuiIcon size="s" type="arrowDown" />
<UtilityBarAction popoverContent={<p>{'Batch actions context menu here.'}</p>}>
{'Batch actions'}
</UtilityBarAction>

<UtilityBarAction>
<EuiIcon size="s" type="arrowDown" /> {'Select all signals on all pages'}
<UtilityBarAction iconType="listAdd">
{'Select all signals on all pages'}
</UtilityBarAction>
</UtilityBarGroup>

<UtilityBarGroup>
<UtilityBarAction>
<EuiIcon size="s" type="cross" /> {'Clear 7 filters'}
</UtilityBarAction>
<UtilityBarAction iconType="cross">{'Clear 7 filters'}</UtilityBarAction>

<UtilityBarAction>
<EuiIcon size="s" type="cross" /> {'Clear aggregation'}
</UtilityBarAction>
<UtilityBarAction iconType="cross">{'Clear aggregation'}</UtilityBarAction>
</UtilityBarGroup>
</UtilityBarSection>

<UtilityBarSection>
<UtilityBarGroup>
<UtilityBarAction>
<EuiIcon size="s" type="cross" /> {'Customize columns'}
<UtilityBarAction popoverContent={<p>{'Customize columns context menu here.'}</p>}>
{'Customize columns'}
</UtilityBarAction>

<UtilityBarAction>
<EuiIcon size="s" type="cross" /> {'Aggregate data'}
</UtilityBarAction>
<UtilityBarAction iconType="indexMapping">{'Aggregate data'}</UtilityBarAction>
</UtilityBarGroup>
</UtilityBarSection>
</UtilityBar>

{/* Datagrid here. Talk to Chandler Prall about possibility of early access. If not possible, use basic table. */}
{/* Open signals datagrid here. Talk to Chandler Prall about possibility of early access. If not possible, use basic table. */}
</EuiPanel>
</StickyContainer>