Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SIEM] Detection engine placeholders #50220

Merged
merged 80 commits into from
Nov 13, 2019
Merged

[SIEM] Detection engine placeholders #50220

merged 80 commits into from
Nov 13, 2019

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Nov 11, 2019

Summary

Detection engine placeholders from @MichaelMarcialis

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

MichaelMarcialis and others added 30 commits October 7, 2019 11:12
@MichaelMarcialis
attempt at getting nav working
f4b0f91
@stephmilovic
fix detection-engine href redirect issue
66a5154
Merge pull request #1 from stephmilovic/michael-detection-engine
178827e 
fix detection-engine href redirect issue
@MichaelMarcialis
rough out basic page routing
7d34c25
@MichaelMarcialis
kql placeholder
1df2e98
@MichaelMarcialis
update page and panel headers
ca77faa
@MichaelMarcialis
Merge branch 'master' of https://github.com/elastic/kibana into featu…
f85d4b7 
…re/siem-team-463/detection-engine-placeholders
@MichaelMarcialis
rough out card table poc styles
ab39bfc
@MichaelMarcialis
change HeaderPanel to HeaderSection
f82a179
@MichaelMarcialis
cleanup and unit test updates
30d5053
@MichaelMarcialis
rough out utilityBar poc
c847e77
@MichaelMarcialis
clean up UtilityBar naming and styles
33b3d33
@MichaelMarcialis
Merge branch 'master' of https://github.com/elastic/kibana into featu…
89c2497 
…re/siem-team-463/detection-engine-placeholders

# Conflicts:
#	x-pack/legacy/plugins/siem/public/pages/network/ip_details.tsx
#	x-pack/legacy/plugins/siem/public/pages/network/network.tsx
@MichaelMarcialis
support popovers in utility bar
a4a8bef
@MichaelMarcialis
refactor icon side
c6f96c6
@MichaelMarcialis
UtilityBar unit tests
8b1b580
@MichaelMarcialis
Merge branch 'master' of https://github.com/elastic/kibana into featu…
f2d7f64 
…re/siem-team-463/detection-engine-placeholders
@MichaelMarcialis
remove page tests for now
d2837d0
@MichaelMarcialis
adjust routes
e2d0a34
@MichaelMarcialis
add comment
955bbc1
@MichaelMarcialis
cleanup chart
3ff9af4
@MichaelMarcialis
open/closed signals content toggle
630e77e
@MichaelMarcialis
Merge branch 'master' of https://github.com/elastic/kibana into featu…
9c934f5 
…re/siem-team-463/detection-engine-placeholders

# Conflicts:
#	x-pack/legacy/plugins/siem/public/components/link_to/link_to.tsx
#	x-pack/legacy/plugins/siem/public/components/navigation/index.tsx
#	x-pack/legacy/plugins/siem/public/components/url_state/constants.ts
#	x-pack/legacy/plugins/siem/public/components/url_state/types.ts
#	x-pack/legacy/plugins/siem/public/pages/network/ip_details.tsx
#	x-pack/legacy/plugins/siem/public/pages/network/network.tsx
@MichaelMarcialis
remove EuiFilterButton icons
91b39b4
@MichaelMarcialis
fix misaligned popover button
9f32e1d
@MichaelMarcialis
add split prop for HeaderSection
4027a65
@MichaelMarcialis
fleshing out activity monitor table
92f063f
@MichaelMarcialis
Merge branch 'master' of https://github.com/elastic/kibana into featu…
a185185 
…re/siem-team-463/detection-engine-placeholders

# Conflicts:
#	x-pack/legacy/plugins/siem/public/components/link_to/link_to.tsx
#	x-pack/legacy/plugins/siem/public/pages/home/home_navigations.tsx
#	x-pack/legacy/plugins/siem/public/pages/home/index.tsx
#	x-pack/legacy/plugins/siem/public/pages/network/ip_details.tsx
@MichaelMarcialis
update global header to include logo
f8c4acb
@MichaelMarcialis
Merge branch 'master' of https://github.com/elastic/kibana into featu…
0e87c82 
…re/siem-team-463/detection-engine-placeholders
spong
spong approved these changes Nov 12, 2019
View reviewed changes
Copy link
Member

@spong spong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out, tested locally, and peer reviewed code over zoom -- LGTM once 💚 👍

Additions from @XavierM and I include:

  • Feature flag for disabling Detection Engine tab
  • Updated selectors for cypress
  • Fixed routing console error
  • Fixed additional types/tests

TODO for @XavierM and I's follow-up PR's:

  • Update translations
  • Update route names (rule/detail/ vs rules/rules-details)

@spong spong mentioned this pull request Nov 12, 2019
Closed
20 tasks
@XavierM
Copy link
Contributor Author

XavierM commented Nov 12, 2019

@elasticmachine merge upstream

@elastic elastic deleted a comment from elasticmachine Nov 12, 2019
@elastic elastic deleted a comment from elasticmachine Nov 13, 2019
@elastic elastic deleted a comment from elasticmachine Nov 13, 2019
@XavierM
Copy link
Contributor Author

XavierM commented Nov 13, 2019

@elasticmachine merge upstream

@elastic elastic deleted a comment from elasticmachine Nov 13, 2019
@elastic elastic deleted a comment from elasticmachine Nov 13, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@XavierM XavierM merged commit 59e0a1c into elastic:master Nov 13, 2019
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 13, 2019
@jloleysens
Merge remote-tracking branch 'upstream/master' into np-migration/ua
b99342b 
* upstream/master:
  Remove internal platform types exports (elastic#50427)
  [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312)
  [Telemetry] Server side fetcher (elastic#50015)
  [SIEM] Detection engine placeholders (elastic#50220)
  [Uptime] Donut chart loader position centered vertically  (elastic#50219)
  update telemetry banner notice text (elastic#50403)
  Fix aborting when searching without batching (elastic#49966)
  [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189)
  Revert chromedriver update (elastic#50324)
  Remove deprecated argument include_type_name from ES calls (elastic#50285)
  [Maps] add settings to maps telemetry (elastic#50161)
  remove visualize loader (elastic#46910)
  Fix misuse of react-router and react-router-dom (elastic#50120)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 13, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into console-proxy…
31fdcec 
…-fallback

* 'master' of github.com:elastic/kibana:
  Remove internal platform types exports (elastic#50427)
  [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312)
  [Telemetry] Server side fetcher (elastic#50015)
  [SIEM] Detection engine placeholders (elastic#50220)
  [Uptime] Donut chart loader position centered vertically  (elastic#50219)
  update telemetry banner notice text (elastic#50403)
  Fix aborting when searching without batching (elastic#49966)
  [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189)
  Revert chromedriver update (elastic#50324)
  Remove deprecated argument include_type_name from ES calls (elastic#50285)
  [Maps] add settings to maps telemetry (elastic#50161)
  remove visualize loader (elastic#46910)
  Fix misuse of react-router and react-router-dom (elastic#50120)
  Move table-list-view to kibana-react (elastic#50046)
  [ML] Stats bar for data frame analytics (elastic#49464)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 13, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into fix/grokdebug…
0c102d9 
…ger-ace-theme

* 'master' of github.com:elastic/kibana: (56 commits)
  [ML] Server info service refactor (elastic#50302)
  Remove internal platform types exports (elastic#50427)
  [APM] Document `apm_oss.metricsIndices` and `apm_oss.sourcemap… (elastic#50312)
  [Telemetry] Server side fetcher (elastic#50015)
  [SIEM] Detection engine placeholders (elastic#50220)
  [Uptime] Donut chart loader position centered vertically  (elastic#50219)
  update telemetry banner notice text (elastic#50403)
  Fix aborting when searching without batching (elastic#49966)
  [Telemetry] Remove telemetry splash page and add conditional messaging (elastic#50189)
  Revert chromedriver update (elastic#50324)
  Remove deprecated argument include_type_name from ES calls (elastic#50285)
  [Maps] add settings to maps telemetry (elastic#50161)
  remove visualize loader (elastic#46910)
  Fix misuse of react-router and react-router-dom (elastic#50120)
  Move table-list-view to kibana-react (elastic#50046)
  [ML] Stats bar for data frame analytics (elastic#49464)
  [ML] Make navigation in tests more stable (elastic#50132)
  Migrate authorization subsystem to the new platform.  (elastic#46145)
  Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063)
  Update dependency @elastic/charts to v14 (elastic#49947)
  ...
@XavierM XavierM mentioned this pull request Nov 18, 2019
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request Nov 18, 2019
@XavierM
[SIEM] Detection engine placeholders (elastic#50220)
a612673 
* attempt at getting nav working

* fix detection-engine href redirect issue

* rough out basic page routing

* kql placeholder

* update page and panel headers

* rough out card table poc styles

* change HeaderPanel to HeaderSection

* cleanup and unit test updates

* rough out utilityBar poc

* clean up UtilityBar naming and styles

* support popovers in utility bar

* refactor icon side

* UtilityBar unit tests

* remove page tests for now

* adjust routes

* add comment

* cleanup chart

* open/closed signals content toggle

* remove EuiFilterButton icons

* fix misaligned popover button

* add split prop for HeaderSection

* fleshing out activity monitor table

* update global header to include logo

* fix tests

* correct table types; thanks Garrett!

* LinkIcon comp poc

* fix bugs, errors, tests

* rm import

* table cleanup

* correct merge errors

* switch All Rules to EuiBasicTable

* expand table types and values

* fleshing out all rules table

* rough out rule details

* move chart to separate comp

* update supplement layout

* example rule fail

* switch to new discover-style search

* add ProgressInline comp

* update unit tests and snapshots

* cleanup

* correct merge weirdness

* move text styles to all subtitle items

* correct invalid nav markup; update tests; cleanup

* fix console errors

* add empty page

* change to EuiButtonEmpty in HeaderGlobal

* overflow popover

* rough out edit layout

* new WrapperPage comp POC

* cleanup

* var for timeline gutter

* tests and snapshots update

* fix type + review + re-arrange code

* adding feature flag + fix route issue

* fix type with unit test

* Removing unused translation
XavierM added a commit that referenced this pull request Nov 18, 2019
@XavierM
[SIEM] Detection engine placeholders (#50220) (#50909)
14579af 
* attempt at getting nav working

* fix detection-engine href redirect issue

* rough out basic page routing

* kql placeholder

* update page and panel headers

* rough out card table poc styles

* change HeaderPanel to HeaderSection

* cleanup and unit test updates

* rough out utilityBar poc

* clean up UtilityBar naming and styles

* support popovers in utility bar

* refactor icon side

* UtilityBar unit tests

* remove page tests for now

* adjust routes

* add comment

* cleanup chart

* open/closed signals content toggle

* remove EuiFilterButton icons

* fix misaligned popover button

* add split prop for HeaderSection

* fleshing out activity monitor table

* update global header to include logo

* fix tests

* correct table types; thanks Garrett!

* LinkIcon comp poc

* fix bugs, errors, tests

* rm import

* table cleanup

* correct merge errors

* switch All Rules to EuiBasicTable

* expand table types and values

* fleshing out all rules table

* rough out rule details

* move chart to separate comp

* update supplement layout

* example rule fail

* switch to new discover-style search

* add ProgressInline comp

* update unit tests and snapshots

* cleanup

* correct merge weirdness

* move text styles to all subtitle items

* correct invalid nav markup; update tests; cleanup

* fix console errors

* add empty page

* change to EuiButtonEmpty in HeaderGlobal

* overflow popover

* rough out edit layout

* new WrapperPage comp POC

* cleanup

* var for timeline gutter

* tests and snapshots update

* fix type + review + re-arrange code

* adding feature flag + fix route issue

* fix type with unit test

* Removing unused translation
@spong spong mentioned this pull request Nov 21, 2019
Merged
26 tasks
@XavierM XavierM deleted the detection-engine-placeholders branch June 4, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

@FrankHassanabad FrankHassanabad Awaiting requested review from FrankHassanabad

Assignees

@MichaelMarcialis MichaelMarcialis

Labels
release_note:enhancement review Team:SIEM v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@XavierM @elasticmachine @spong @MichaelMarcialis @stephmilovic