Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Remove dependent sub suite structure from test files #49059

Merged
merged 2 commits into from
Oct 24, 2019

Conversation

pheyos
Copy link
Member

@pheyos pheyos commented Oct 23, 2019

Summary

With the changes planned in #48683 test suites defined via describe should be completely independent. The current test file structure in ML tests contains sub suites that depend on each other. This PR removes those sub suites (and moves the name into each it, so the reporter output should be the same), such that all test steps that are dependent on each other are executed in one big suite.

Change details

  • Removed sub suite levels (describe('job creation', function() {, same for job cloning and job deletion)
  • all contained test steps (it blocks) are now contained in the main suite (e.g. describe('single metric', function() {)
  • all test steps descriptions now contain the title of the removed sub suite, e.g.
    describe('job creation', function() {
        it('loads the job management page', async () => {
    
    is now
    it('job creation loads the job management page', async () => {
    

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@pheyos pheyos added the release_note:skip Skip the PR/issue when compiling release notes label Oct 23, 2019
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@pheyos pheyos merged commit 2ff021b into elastic:master Oct 24, 2019
@pheyos pheyos deleted the remove_sub_suites branch October 24, 2019 12:33
pheyos added a commit to pheyos/kibana that referenced this pull request Oct 25, 2019
)

This PR removes the sub suites from all ML test files, such that all test steps that are dependent on each other are executed in one big suite.
pheyos added a commit to pheyos/kibana that referenced this pull request Oct 25, 2019
)

This PR removes the sub suites from all ML test files, such that all test steps that are dependent on each other are executed in one big suite.
pheyos added a commit that referenced this pull request Oct 25, 2019
…49317)

This PR removes the sub suites from all ML test files, such that all test steps that are dependent on each other are executed in one big suite.
pheyos added a commit that referenced this pull request Oct 25, 2019
…49319)

This PR removes the sub suites from all ML test files, such that all test steps that are dependent on each other are executed in one big suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants