Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTR: clear browser storage between test suites #48683

Merged
merged 7 commits into from
Oct 28, 2019
Merged

FTR: clear browser storage between test suites #48683

merged 7 commits into from
Oct 28, 2019

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Oct 18, 2019 •
edited
Loading

Summary

In order to make test suites independent from browser perspective, we can clean session and local storages after each describe function. In this case describe block cannot rely on previous file/describe block to finish at some point and should handle pre-conditions on its own.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@pheyos pheyos mentioned this pull request Oct 23, 2019
Merged
@spalger
Copy link
Contributor

spalger commented Oct 25, 2019

@elasticmachine merge upstream

spalger
spalger approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko dmlemeshko marked this pull request as ready for review October 25, 2019 23:52
@dmlemeshko dmlemeshko added release_note:skip Skip the PR/issue when compiling release notes v8.0.0 v7.6.0 labels Oct 25, 2019
@dmlemeshko dmlemeshko requested a review from LeeDr October 25, 2019 23:56
@dmlemeshko
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 26, 2019 •
edited by dmlemeshko
Loading

💔 Build Failed

Xpack-ciGroup3

  1. machine learning
    anomaly detection
    saved search
    with filter
    job creation loads the job type selection page:
    Error: expected testSubject(mlPageJobTypeSelection) to exist
    at TestSubjects.existOrFail (/dev/shm/workspace/kibana/test/functional/services/test_subjects.ts:60:15)
    at process._tickCallback (internal/process/next_tick.js:68:7)

@dmlemeshko
Copy link
Member Author

retest

@dmlemeshko dmlemeshko requested a review from a team as a code owner October 27, 2019 22:59
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko dmlemeshko requested a review from pheyos October 28, 2019 02:03
pheyos
pheyos approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@pheyos pheyos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmlemeshko
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@dmlemeshko dmlemeshko merged commit d9a5acf into elastic:master Oct 28, 2019
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Oct 28, 2019
@dmlemeshko
FTR: clear browser storage between test suites (elastic#48683)
d3057cb 
* clear browser storage on test suite completion

* [logstash/pipeline_list] fix tests dependency

* always load new index data
@dmlemeshko dmlemeshko mentioned this pull request Oct 28, 2019
Merged
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Oct 28, 2019
@dmlemeshko
FTR: clear browser storage between test suites (elastic#48683)
5b81441 
* clear browser storage on test suite completion

* [logstash/pipeline_list] fix tests dependency

* always load new index data
@dmlemeshko dmlemeshko mentioned this pull request Oct 28, 2019
Merged
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request Oct 28, 2019
@dmlemeshko
FTR: clear browser storage between test suites (elastic#48683)
5a0e28e 
* clear browser storage on test suite completion

* [logstash/pipeline_list] fix tests dependency

* always load new index data
@dmlemeshko dmlemeshko mentioned this pull request Oct 28, 2019
Merged
dmlemeshko added a commit that referenced this pull request Oct 28, 2019
@dmlemeshko
FTR: clear browser storage between test suites (#48683) (#49475)
0cff839 
* clear browser storage on test suite completion

* [logstash/pipeline_list] fix tests dependency

* always load new index data
dmlemeshko added a commit that referenced this pull request Oct 28, 2019
@dmlemeshko
FTR: clear browser storage between test suites (#48683) (#49476)
23ac9b6 
* clear browser storage on test suite completion

* [logstash/pipeline_list] fix tests dependency

* always load new index data
dmlemeshko added a commit that referenced this pull request Nov 7, 2019
@dmlemeshko
[7.4] FTR: clear browser storage between test suites (#48683) (#49477)
331be3c 
* FTR: clear browser storage between test suites (#48683)

* clear browser storage on test suite completion

* [logstash/pipeline_list] fix tests dependency

* always load new index data

* remove files
@dmlemeshko dmlemeshko deleted the ftr/clear-browser-storage-between-tests branch January 31, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pheyos pheyos pheyos approved these changes

@spalger spalger spalger approved these changes

@LeeDr LeeDr Awaiting requested review from LeeDr

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.5.1 v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmlemeshko @elasticmachine @spalger @pheyos