Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] add unique count metric aggregation #48961

Merged
merged 6 commits into from
Oct 24, 2019
Merged

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Oct 22, 2019

Fixes #34025

This PR adds cardinality metric aggregation for grid source, pew pew source, and terms joins.

Both coordinate map and region map visualizations allow for cardinality metric aggregation. This PR closes the gap between maps application and legacy mapping visualizations.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese
Copy link
Contributor Author

nreese commented Oct 24, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice add. You can make maps like unique users/visits per country now, which is very useful for the logging/metrics use-case.

Some of the renames (count-constant, getFieldFormatter) will clash with #49068, but since this is a known quantity, feel free to merge..

@nreese nreese merged commit 48313f7 into elastic:master Oct 24, 2019
nreese added a commit to nreese/kibana that referenced this pull request Oct 24, 2019
* [Maps] add unique count metric aggregation

* do not format unique_count aggregation results

* do not format value in legend for unique count

* update heatmap docs

* one more doc change
nreese added a commit that referenced this pull request Oct 25, 2019
* [Maps] add unique count metric aggregation

* do not format unique_count aggregation results

* do not format value in legend for unique count

* update heatmap docs

* one more doc change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Maps] Support all metrics from visualize region and coordinate maps
3 participants