You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getName() //unique name of the field
isValid() //whether it is usable (e.g. partial field configs can arise when editing)
async getType() //data-type of the field, string, number, etc...
async getLabel() //display of the field
async createTooltipProperty()//create corresponding tooltip entry
Introduces 4 field types (x-pack/legacy/plugins/maps/public/layers/fields)
EMSRegionField: fields from EMS
ESAggField: fields that wrap results of aggs (e.g. geogrid-sources, or term-join metrics)
ESDocField: fields from ES-index pattern
KibanaRegionField: todo
Introduces AbstractESAggSource class (DONE in #49782)
top-level for ESGeoGridSource, ESPewPewSource, ESTermSource
Removes agg-formatting duplication and field-creation
Organizes style-modules and related react-components by type (DONE in #49803)
This seems to relate to discussions in #35481 and #44955 and plans to think up the spiritual successor of index patterns (about which there'll be a session next week)
This seems to relate to discussions in #35481 and #44955 and plans to think up the spiritual successor of index patterns (about which there'll be a session next week)
No, this is unrelated to those discussions. This PR just adds a fields class to the Maps app to consolidate custom labels, formatters, and meta data like max and min and percentiles.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP
Do not merge. This is for exploration only. Work will be split up into multiple smaller PRs.
Prereq:
This makes following changes to the code base.
Introduces field interface
Introduces 4 field types (
x-pack/legacy/plugins/maps/public/layers/fields
)EMSRegionField
: fields from EMSESAggField
: fields that wrap results of aggs (e.g. geogrid-sources, or term-join metrics)ESDocField
: fields from ES-index patternKibanaRegionField
: todoIntroduces(DONE in #49782)AbstractESAggSource
classESGeoGridSource
,ESPewPewSource
,ESTermSource
Organizes style-modules and related react-components by type(DONE in #49803)x-pack/legacy/plugins/maps/public/layers/styles/heatmap
x-pack/legacy/plugins/maps/public/layers/styles/vector
Add typing for all vector-style-properties(done in #49803)(
x-pack/legacy/plugins/maps/public/layers/styles/vector/properties
)dynamic_*_property
: style-properties bound to a fieldstatic_*_property
: static propertiesThis also removes the duplicated branching-code from all mb-syncing operations
Introduce fields as top-level concept.
Fields are scattered and inconsistent throughout the code-base right now, wrt. display, config, and typing.
Fields
should be used consistently for:-- left field definitions
-- right field definitions
-- for grid source
-- for pewpew source
Fields are source-dependent
Later, fields should also be used for